Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4356)

Unified Diff: cc/surfaces/surface_id_allocator.h

Issue 2166423002: ui::ContextFactory should not create SurfaceIdAllocators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Dana's nit Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « cc/surfaces/display_unittest.cc ('k') | cc/surfaces/surface_id_allocator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/surfaces/surface_id_allocator.h
diff --git a/cc/surfaces/surface_id_allocator.h b/cc/surfaces/surface_id_allocator.h
index c77f3595dbb1657a55808c16e2202f577ff42e84..5ed3b117e8bd849d195224cd90f2a8748dcf7172 100644
--- a/cc/surfaces/surface_id_allocator.h
+++ b/cc/surfaces/surface_id_allocator.h
@@ -25,24 +25,11 @@ class CC_SURFACES_EXPORT SurfaceIdAllocator {
SurfaceId GenerateId();
- // This needs to be called before any sequences with this allocator's
- // namespace will be used to enforce destruction dependencies.
- // When this SurfaceIdAllocator is destroyed, its namespace is
- // automatically invalidated and any remaining sequences with that
- // namespace will be ignored. This method does not need to be called in
- // contexts where there is no SurfaceManager (e.g. a renderer process).
- void RegisterSurfaceClientId(SurfaceManager* manager);
-
uint32_t client_id() const { return client_id_; }
- // SurfaceIdAllocator's owner can call this when it find out that
- // SurfaceManager is no longer alive during destruction.
- void DidDestroySurfaceManager() { manager_ = nullptr; }
-
private:
const uint32_t client_id_;
uint32_t next_id_;
- SurfaceManager* manager_;
DISALLOW_COPY_AND_ASSIGN(SurfaceIdAllocator);
};
« no previous file with comments | « cc/surfaces/display_unittest.cc ('k') | cc/surfaces/surface_id_allocator.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698