content/browser/renderer_host/offscreen_canvas_surface_impl.cc - Issue 2166423002: ui::ContextFactory should not create SurfaceIdAllocators

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/renderer_host/offscreen_canvas_surface_impl.cc

Issue 2166423002: ui::ContextFactory should not create SurfaceIdAllocators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fixed Android + Addressed Antoine's comment Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/compositor/gpu_process_transport_factory.cc ('K') | « content/browser/renderer_host/delegated_frame_host.cc ('k') | content/browser/renderer_host/render_widget_host_view_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/renderer_host/offscreen_canvas_surface_impl.cc

diff --git a/content/browser/renderer_host/offscreen_canvas_surface_impl.cc b/content/browser/renderer_host/offscreen_canvas_surface_impl.cc

index 5689bff4b0192c45746ad98092453689972df6d1..b3329778c8dea0e120f63fa6175accb4a098b694 100644

--- a/content/browser/renderer_host/offscreen_canvas_surface_impl.cc

+++ b/content/browser/renderer_host/offscreen_canvas_surface_impl.cc

@@ -21,7 +21,7 @@ void OffscreenCanvasSurfaceImpl::Create(

OffscreenCanvasSurfaceImpl::OffscreenCanvasSurfaceImpl(

mojo::InterfaceRequest<blink::mojom::OffscreenCanvasSurface> request)

- : id_allocator_(CreateSurfaceIdAllocator()),

+ : id_allocator_(new cc::SurfaceIdAllocator(AllocateSurfaceClientId())),

binding_(this, std::move(request)) {}

OffscreenCanvasSurfaceImpl::~OffscreenCanvasSurfaceImpl() {