Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(91)

Side by Side Diff: content/browser/renderer_host/offscreen_canvas_surface_impl.cc

Issue 2166423002: ui::ContextFactory should not create SurfaceIdAllocators (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed Android + Addressed Antoine's comment Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "content/browser/renderer_host/offscreen_canvas_surface_impl.h" 5 #include "content/browser/renderer_host/offscreen_canvas_surface_impl.h"
6 6
7 #include "base/bind_helpers.h" 7 #include "base/bind_helpers.h"
8 #include "cc/surfaces/surface.h" 8 #include "cc/surfaces/surface.h"
9 #include "cc/surfaces/surface_manager.h" 9 #include "cc/surfaces/surface_manager.h"
10 #include "content/browser/compositor/surface_utils.h" 10 #include "content/browser/compositor/surface_utils.h"
11 #include "content/public/browser/browser_thread.h" 11 #include "content/public/browser/browser_thread.h"
12 12
13 namespace content { 13 namespace content {
14 14
15 // static 15 // static
16 void OffscreenCanvasSurfaceImpl::Create( 16 void OffscreenCanvasSurfaceImpl::Create(
17 mojo::InterfaceRequest<blink::mojom::OffscreenCanvasSurface> request) { 17 mojo::InterfaceRequest<blink::mojom::OffscreenCanvasSurface> request) {
18 // |binding_| will take ownership of OffscreenCanvasSurfaceImpl 18 // |binding_| will take ownership of OffscreenCanvasSurfaceImpl
19 new OffscreenCanvasSurfaceImpl(std::move(request)); 19 new OffscreenCanvasSurfaceImpl(std::move(request));
20 } 20 }
21 21
22 OffscreenCanvasSurfaceImpl::OffscreenCanvasSurfaceImpl( 22 OffscreenCanvasSurfaceImpl::OffscreenCanvasSurfaceImpl(
23 mojo::InterfaceRequest<blink::mojom::OffscreenCanvasSurface> request) 23 mojo::InterfaceRequest<blink::mojom::OffscreenCanvasSurface> request)
24 : id_allocator_(CreateSurfaceIdAllocator()), 24 : id_allocator_(new cc::SurfaceIdAllocator(AllocateSurfaceClientId())),
25 binding_(this, std::move(request)) {} 25 binding_(this, std::move(request)) {}
26 26
27 OffscreenCanvasSurfaceImpl::~OffscreenCanvasSurfaceImpl() { 27 OffscreenCanvasSurfaceImpl::~OffscreenCanvasSurfaceImpl() {
28 if (!GetSurfaceManager()) { 28 if (!GetSurfaceManager()) {
29 // Inform both members that SurfaceManager's no longer alive to 29 // Inform both members that SurfaceManager's no longer alive to
30 // avoid their destruction errors. 30 // avoid their destruction errors.
31 if (surface_factory_) 31 if (surface_factory_)
32 surface_factory_->DidDestroySurfaceManager(); 32 surface_factory_->DidDestroySurfaceManager();
33 if (id_allocator_) 33 if (id_allocator_)
34 id_allocator_->DidDestroySurfaceManager(); 34 id_allocator_->DidDestroySurfaceManager();
(...skipping 43 matching lines...) Expand 10 before | Expand all | Expand 10 after
78 const cc::ReturnedResourceArray& resources) {} 78 const cc::ReturnedResourceArray& resources) {}
79 79
80 void OffscreenCanvasSurfaceImpl::WillDrawSurface(const cc::SurfaceId& id, 80 void OffscreenCanvasSurfaceImpl::WillDrawSurface(const cc::SurfaceId& id,
81 const gfx::Rect& damage_rect) { 81 const gfx::Rect& damage_rect) {
82 } 82 }
83 83
84 void OffscreenCanvasSurfaceImpl::SetBeginFrameSource( 84 void OffscreenCanvasSurfaceImpl::SetBeginFrameSource(
85 cc::BeginFrameSource* begin_frame_source) {} 85 cc::BeginFrameSource* begin_frame_source) {}
86 86
87 } // namespace content 87 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698