Issue 216633002: Reduce type-impedance for ExceptionMessages::failedTo* functions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 216633002: Reduce type-impedance for ExceptionMessages::failedTo* functions (Closed)

Created:
6 years, 9 months ago by fs

Modified:
6 years, 9 months ago

Reviewers:
haraken, jochen (gone - plz use gerrit), Mike West

CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, kouhei+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Reduce type-impedance for ExceptionMessages::failedTo* functions These functions are always called with string literals, so having the functions accept Strings means all callers have to perform implicit conversions. By modifying the signatures to use 'const char*' for these cases, these conversion can be avoided (in the callers) and only be performed in the functions themselves. This reduces code size by ~70kB (Linux, x86-64, gcc-4.8.2). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170304

Patch Set 1 #

Created: 6 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+30 lines, -30 lines)			Patch
	M	Source/bindings/v8/ExceptionMessages.h	View		1 chunk	+11 lines, -11 lines	0 comments	Download
	M	Source/bindings/v8/ExceptionMessages.cpp	View		1 chunk	+19 lines, -19 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/216633002/1

6 years, 9 months ago (2014-03-28 08:42:16 UTC) #4

Message was sent while issue was closed.

Change committed as 170304

Expand Messages | Collapse Messages