Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Unified Diff: Source/bindings/v8/ExceptionMessages.h

Issue 216633002: Reduce type-impedance for ExceptionMessages::failedTo* functions (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | Source/bindings/v8/ExceptionMessages.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/ExceptionMessages.h
diff --git a/Source/bindings/v8/ExceptionMessages.h b/Source/bindings/v8/ExceptionMessages.h
index f78a6f4a971b883b784c70a4915ec18fd061b6d2..6a5e6d735d6c9fd51013183b83451683386bc7b0 100644
--- a/Source/bindings/v8/ExceptionMessages.h
+++ b/Source/bindings/v8/ExceptionMessages.h
@@ -47,17 +47,17 @@ public:
};
static String argumentNullOrIncorrectType(int argumentIndex, const String& expectedType);
- static String constructorNotCallableAsFunction(const String& type);
-
- static String failedToConstruct(const String& type, const String& detail);
- static String failedToEnumerate(const String& type, const String& detail);
- static String failedToExecute(const String& method, const String& type, const String& detail);
- static String failedToGet(const String& property, const String& type, const String& detail);
- static String failedToSet(const String& property, const String& type, const String& detail);
- static String failedToDelete(const String& property, const String& type, const String& detail);
- static String failedToGetIndexed(const String& type, const String& detail);
- static String failedToSetIndexed(const String& type, const String& detail);
- static String failedToDeleteIndexed(const String& type, const String& detail);
+ static String constructorNotCallableAsFunction(const char* type);
+
+ static String failedToConstruct(const char* type, const String& detail);
+ static String failedToEnumerate(const char* type, const String& detail);
+ static String failedToExecute(const char* method, const char* type, const String& detail);
+ static String failedToGet(const char* property, const char* type, const String& detail);
+ static String failedToSet(const char* property, const char* type, const String& detail);
+ static String failedToDelete(const char* property, const char* type, const String& detail);
+ static String failedToGetIndexed(const char* type, const String& detail);
+ static String failedToSetIndexed(const char* type, const String& detail);
+ static String failedToDeleteIndexed(const char* type, const String& detail);
template <typename NumType>
static String formatNumber(NumType number)
« no previous file with comments | « no previous file | Source/bindings/v8/ExceptionMessages.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698