Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(449)

Issue 2166273002: Only flag the LayoutObject on CSP error if one is attached (Closed)

Created:
4 years, 5 months ago by fs
Modified:
4 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Only flag the LayoutObject on CSP error if one is attached When instantiating a plugin through the (somewhat special) code-path that does not require a LayoutObject to be present, we would end up dereferencing a null-pointer if a CSP error was flagged, failing the plugin load sequence. BUG=627694 Review-Url: https://codereview.chromium.org/2162473003 Cr-Commit-Position: refs/heads/master@{#406295} (cherry picked from commit 386e769dbd70b39c348bd663749858f117654408) Committed: https://chromium.googlesource.com/chromium/src/+/6899c4fef931853289e2a042e87c01b2aa69e88b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/fast/plugins/plugin-without-layout-csp-error-crash.html View 1 chunk +9 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/plugins/plugin-without-layout-csp-error-crash-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
fs
4 years, 5 months ago (2016-07-21 10:30:17 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6899c4fef931853289e2a042e87c01b2aa69e88b.

Powered by Google App Engine
This is Rietveld 408576698