Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Issue 2162473003: Only flag the LayoutObject on CSP error if one is attached (Closed)

Created:
4 years, 5 months ago by fs
Modified:
4 years, 5 months ago
Reviewers:
tkent, Mike West
CC:
blink-reviews, blink-reviews-html_chromium.org, chromium-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Only flag the LayoutObject on CSP error if one is attached When instantiating a plugin through the (somewhat special) code-path that does not require a LayoutObject to be present, we would end up dereferencing a null-pointer if a CSP error was flagged, failing the plugin load sequence. BUG=627694 Committed: https://crrev.com/386e769dbd70b39c348bd663749858f117654408 Cr-Commit-Position: refs/heads/master@{#406295}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -3 lines) Patch
A third_party/WebKit/LayoutTests/fast/plugins/plugin-without-layout-csp-error-crash.html View 1 chunk +9 lines, -0 lines 0 comments Download
A + third_party/WebKit/LayoutTests/fast/plugins/plugin-without-layout-csp-error-crash-expected.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
fs
4 years, 5 months ago (2016-07-18 12:12:26 UTC) #4
fs
On 2016/07/18 at 12:12:26, fs wrote: > Ping!
4 years, 5 months ago (2016-07-19 12:54:38 UTC) #7
Mike West
LGTM, thanks for ensuring that there's a test for this!
4 years, 5 months ago (2016-07-19 13:47:12 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2162473003/1
4 years, 5 months ago (2016-07-19 13:51:03 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 16:50:57 UTC) #11
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 16:51:00 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 16:53:08 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/386e769dbd70b39c348bd663749858f117654408
Cr-Commit-Position: refs/heads/master@{#406295}

Powered by Google App Engine
This is Rietveld 408576698