Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2166253002:
gn: Guard windows compiler flag with the supporting msvs version (Closed)
|
Created:
4 years, 5 months ago by Michael Achenbach Modified:
4 years, 5 months ago CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
Descriptiongn: Guard windows compiler flag with the supporting msvs version
The flags /d2fastfail and /fastfail are not supported by
msvs version 2013, which is still used by V8.
BUG=chromium:474921
Committed: https://crrev.com/b823b8af2358c5e811b3185d696a59ec5f530b1e
Cr-Commit-Position: refs/heads/master@{#406907}
Patch Set 1 #
Total comments: 1
Messages
Total messages: 18 (12 generated)
Description was changed from ========== gn: Guard windows compiler flag by supporting msvs version BUG= ========== to ========== gn: Guard windows compiler flag by supporting msvs version BUG=chromium:474921 ==========
machenbach@chromium.org changed reviewers: + brucedawson@chromium.org, dpranke@chromium.org, jochen@chromium.org, scottmg@chromium.org
Description was changed from ========== gn: Guard windows compiler flag by supporting msvs version BUG=chromium:474921 ========== to ========== gn: Guard windows compiler flag by supporting msvs version The flags /d2fastfail and /fastfail are not supported by msvs version 2013, which is still used by V8. BUG=chromium:474921 ==========
machenbach@chromium.org changed reviewers: - scottmg@chromium.org
PTAL - result of discussion on gn-dev: https://groups.google.com/a/chromium.org/forum/#!topic/gn-dev/KHtWF2NQ5N4 https://codereview.chromium.org/2166253002/diff/1/build/config/win/BUILD.gn File build/config/win/BUILD.gn (right): https://codereview.chromium.org/2166253002/diff/1/build/config/win/BUILD.gn#n... build/config/win/BUILD.gn:48: # Flags not supported in version 2013. We could also add this to the 2015 case below, but I thought this way eases switching to a newer version without having to modify this code.
Description was changed from ========== gn: Guard windows compiler flag by supporting msvs version The flags /d2fastfail and /fastfail are not supported by msvs version 2013, which is still used by V8. BUG=chromium:474921 ========== to ========== gn: Guard windows compiler flag with the supporting msvs version The flags /d2fastfail and /fastfail are not supported by msvs version 2013, which is still used by V8. BUG=chromium:474921 ==========
The CQ bit was checked by machenbach@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm
The CQ bit was checked by machenbach@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== gn: Guard windows compiler flag with the supporting msvs version The flags /d2fastfail and /fastfail are not supported by msvs version 2013, which is still used by V8. BUG=chromium:474921 ========== to ========== gn: Guard windows compiler flag with the supporting msvs version The flags /d2fastfail and /fastfail are not supported by msvs version 2013, which is still used by V8. BUG=chromium:474921 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== gn: Guard windows compiler flag with the supporting msvs version The flags /d2fastfail and /fastfail are not supported by msvs version 2013, which is still used by V8. BUG=chromium:474921 ========== to ========== gn: Guard windows compiler flag with the supporting msvs version The flags /d2fastfail and /fastfail are not supported by msvs version 2013, which is still used by V8. BUG=chromium:474921 Committed: https://crrev.com/b823b8af2358c5e811b3185d696a59ec5f530b1e Cr-Commit-Position: refs/heads/master@{#406907} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/b823b8af2358c5e811b3185d696a59ec5f530b1e Cr-Commit-Position: refs/heads/master@{#406907} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
