gn: Guard windows compiler flag with the supporting msvs version

build/config/win/BUILD.gn

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/clang/clang.gni")
 import("//build/config/compiler/compiler.gni")
 import("//build/config/sanitizers/sanitizers.gni")
 import("//build/config/win/visual_studio_version.gni")
 import("//build/toolchain/toolchain.gni")
 
@@ skipping 19 matching lines @@
       # valid for the image. Note that /SAFESEH isn't accepted on the command
       # line, only /safeseh. This is only accepted by ml.exe, not ml64.exe.
       "/safeseh",
     ]
   }
 
   cflags = [
     "/Gy",  # Enable function-level linking.
     "/FS",  # Preserve previous PDB behavior.
     "/bigobj",  # Some of our files are bigger than the regular limits.
-
-    # Tell the compiler to crash on failures. This is undocumented
-    # and unsupported but very handy.
-    "/d2FastFail",
   ]
 
   # Force C/C++ mode for the given GN detected file type. This is necessary
   # for precompiled headers where the same source file is compiled in both
   # modes.
   cflags_c = [ "/TC" ]
   cflags_cc = [ "/TP" ]
 
+  # Flags not supported in version 2013.

[Michael Achenbach, 2016/07/21 09:03:19]

We could also add this to the 2015 case below, but I thought this way eases
switching to a newer version without having to modify this code.

+  if (visual_studio_version != "2013" && visual_studio_version != "2013e") {
+    cflags += [
+      # Tell the compiler to crash on failures. This is undocumented
+      # and unsupported but very handy.
+      "/d2FastFail",
+    ]
+  }
+
   if (visual_studio_version == "2015") {
     cflags += [
       # Work around crbug.com/526851, bug in VS 2015 RTM compiler.
       "/Zc:sizedDealloc-",
 
       # Disable thread-safe statics to avoid overhead and because
       # they are disabled on other platforms. See crbug.com/587210
       # and -fno-threadsafe-statics.
       "/Zc:threadSafeInit-",
     ]
@@ skipping 191 matching lines @@
     "/ignore:4199",
     "/ignore:4221",
     "/NXCOMPAT",
 
     # Suggested by Microsoft Devrel to avoid
     #   LINK : fatal error LNK1248: image size (80000000)
     #   exceeds maximum allowable size (80000000)
     # which started happening more regularly after VS2013 Update 4.
     # Needs to be a bit lower for VS2015, or else errors out.
     "/maxilksize:0x7ff00000",
+  ]
 
-    # Tell the linker to crash on failures.
-    "/fastfail",
-  ]
+  # Flags not supported in version 2013.
+  if (visual_studio_version != "2013" && visual_studio_version != "2013e") {
+    ldflags += [
+      # Tell the linker to crash on failures.
+      "/fastfail",
+    ]
+  }
 
   # ASLR makes debugging with windbg difficult because Chrome.exe and
   # Chrome.dll share the same base name. As result, windbg will name the
   # Chrome.dll module like chrome_<base address>, where <base address>
   # typically changes with each launch. This in turn means that breakpoints in
   # Chrome.dll don't stick from one launch to the next. For this reason, we
   # turn ASLR off in debug builds.
   if (is_debug) {
     ldflags += [ "/DYNAMICBASE:NO" ]
   } else {
@@ skipping 105 matching lines @@
 
 # Internal stuff --------------------------------------------------------------
 
 # Config used by the MIDL template to disable warnings.
 config("midl_warnings") {
   if (is_clang) {
     # MIDL generates code like "#endif !_MIDL_USE_GUIDDEF_".
     cflags = [ "-Wno-extra-tokens" ]
   }
 }