Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(944)

Issue 2166193003: Add Breakpad codereview.settings entry for Gerrit (Closed)

Created:
3 years, 8 months ago by agable
Modified:
3 years, 8 months ago
Reviewers:
Mark Mentovai
CC:
google-breakpad-dev_googlegroups.com
Base URL:
https://chromium.googlesource.com/breakpad/breakpad@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Remove comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M codereview.settings View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
agable
3 years, 8 months ago (2016-07-21 17:50:21 UTC) #1
Mark Mentovai
https://codereview.chromium.org/2166193003/diff/1/codereview.settings File codereview.settings (right): https://codereview.chromium.org/2166193003/diff/1/codereview.settings#newcode1 codereview.settings:1: # This file is used by gcl to get ...
3 years, 8 months ago (2016-07-21 17:54:51 UTC) #2
Bons
Adding tandrii@ to answer why the two codereview.settings files are different.
3 years, 8 months ago (2016-07-21 18:04:00 UTC) #4
agable
https://codereview.chromium.org/2166193003/diff/1/codereview.settings File codereview.settings (right): https://codereview.chromium.org/2166193003/diff/1/codereview.settings#newcode1 codereview.settings:1: # This file is used by gcl to get ...
3 years, 8 months ago (2016-07-21 18:05:23 UTC) #6
Mark Mentovai
Superb. Thanks, LGTM. (If this flipped the default, I would have asked for a day ...
3 years, 8 months ago (2016-07-21 19:00:25 UTC) #7
agable
3 years, 8 months ago (2016-07-21 19:45:24 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
0e4af9d8f9779a56884a54848e6a2c44d97d45d8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698