Add Breakpad codereview.settings entry for Gerrit

Add Breakpad codereview.settings entry for Gerrit

R=mark@chromium.org
BUG=629864
Committed: https://chromium.googlesource.com/breakpad/breakpad/+/0e4af9d8f9779a56884a54848e6a2c44d97d45d8

[Mark Mentovai, 2016-07-21 17:54:51]

https://codereview.chromium.org/2166193003/diff/1/codereview.settings
File codereview.settings (right):

https://codereview.chromium.org/2166193003/diff/1/codereview.settings#newcode1
codereview.settings:1: # This file is used by gcl to get repository specific
information.
Remove the obsolete comment, everyone should be using git-cl now.

https://codereview.chromium.org/2166193003/diff/1/codereview.settings#newcode6
codereview.settings:6: GERRIT_SQUASH_UPLOADS: true
GERRIT_HOST? CODEREVIEW_SERVER?

Basically, why is this different from
https://chromium.googlesource.com/crashpad/crashpad/+/a392a2c3ed480cd80b2608c...

[Bons, 2016-07-21 18:04:00]

andybons@chromium.org changed reviewers:
+ andybons@chromium.org, tandrii@chromium.org

[Bons, 2016-07-21 18:04:00]

Adding tandrii@ to answer why the two codereview.settings files are different.

[agable, 2016-07-21 18:05:23]

agable@chromium.org changed reviewers:
- andybons@chromium.org, tandrii@chromium.org

[agable, 2016-07-21 18:05:23]

https://codereview.chromium.org/2166193003/diff/1/codereview.settings
File codereview.settings (right):

https://codereview.chromium.org/2166193003/diff/1/codereview.settings#newcode1
codereview.settings:1: # This file is used by gcl to get repository specific
information.
On 2016/07/21 at 17:54:51, Mark Mentovai wrote:
> Remove the obsolete comment, everyone should be using git-cl now.

Good call, done.

https://codereview.chromium.org/2166193003/diff/1/codereview.settings#newcode6
codereview.settings:6: GERRIT_SQUASH_UPLOADS: true
On 2016/07/21 at 17:54:51, Mark Mentovai wrote:
> GERRIT_HOST? CODEREVIEW_SERVER?
> 
> Basically, why is this different from
https://chromium.googlesource.com/crashpad/crashpad/+/a392a2c3ed480cd80b2608c...

Because setting those causes git-cl to use Gerrit by default; what I'm doing now
is just enabling use of gerrit with the 'git cl upload --gerrit' flag.

[Mark Mentovai, 2016-07-21 19:00:25]

Superb. Thanks, LGTM.

(If this flipped the default, I would have asked for a day or two to announce
the change to google-breakpad-dev first. Now, I’ll wait for you guys to tell me
when to announce it.)

[agable, 2016-07-21 19:45:23]

Description was changed from

==========
Add Breakpad codereview.settings entry for Gerrit

R=mark@chromium.org
BUG=629864
==========

to

==========
Add Breakpad codereview.settings entry for Gerrit

R=mark@chromium.org
BUG=629864

Committed:
https://chromium.googlesource.com/breakpad/breakpad/+/0e4af9d8f9779a56884a548...
==========

[agable, 2016-07-21 19:45:24]

Committed patchset #2 (id:20001) manually as
0e4af9d8f9779a56884a54848e6a2c44d97d45d8 (presubmit successful).