codereview.settings - Issue 2166193003: Add Breakpad codereview.settings entry for Gerrit

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: codereview.settings

Issue 2166193003: Add Breakpad codereview.settings entry for Gerrit (Closed) Base URL: https://chromium.googlesource.com/breakpad/breakpad@master

Patch Set: Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
1 # This file is used by gcl to get repository specific information.	1 # This file is used by gcl to get repository specific information.
	Mark Mentovai 2016/07/21 17:54:51 Remove the obsolete comment, everyone should be us Remove the obsolete comment, everyone should be using git-cl now. agable 2016/07/21 18:05:23 Good call, done. Show quoted text On 2016/07/21 at 17:54:51, Mark Mentovai wrote: > Remove the obsolete comment, everyone should be using git-cl now. Good call, done.
2 CODE_REVIEW_SERVER: codereview.chromium.org	2 CODE_REVIEW_SERVER: codereview.chromium.org

3 CC_LIST: google-breakpad-dev@googlegroups.com	3 CC_LIST: google-breakpad-dev@googlegroups.com

4 TRY_ON_UPLOAD: False	4 TRY_ON_UPLOAD: False

5 VIEW_VC: https://chromium.googlesource.com/breakpad/breakpad/+/	5 VIEW_VC: https://chromium.googlesource.com/breakpad/breakpad/+/

	6 GERRIT_SQUASH_UPLOADS: true
	Mark Mentovai 2016/07/21 17:54:51 GERRIT_HOST? CODEREVIEW_SERVER? Basically, why is GERRIT_HOST? CODEREVIEW_SERVER? Basically, why is this different from https://chromium.googlesource.com/crashpad/crashpad/+/a392a2c3ed480cd80b2608c... agable 2016/07/21 18:05:23 Because setting those causes git-cl to use Gerrit Show quoted text On 2016/07/21 at 17:54:51, Mark Mentovai wrote: > GERRIT_HOST? CODEREVIEW_SERVER? > > Basically, why is this different from https://chromium.googlesource.com/crashpad/crashpad/+/a392a2c3ed480cd80b2608c... Because setting those causes git-cl to use Gerrit by default; what I'm doing now is just enabling use of gerrit with the 'git cl upload --gerrit' flag.
OLD	NEW

« no previous file with comments | « no previous file | no next file » | no next file with comments »