Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Issue 216613003: Don't crash if we get a timezone change notification on an uninitialized isolate (Closed)

Created:
6 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
6 years, 9 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Visibility:
Public.

Description

Don't crash if we get a timezone change notification on an uninitialized isolate Also make the date cache's timestamp more robust. BUG=357362 R=svenpanne@chromium.org LOG=y Committed: https://code.google.com/p/v8/source/detail?r=20323

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M src/api.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/date.cc View 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jochen (gone - plz use gerrit)
6 years, 9 months ago (2014-03-28 08:43:54 UTC) #1
Sven Panne
lgtm
6 years, 9 months ago (2014-03-28 08:47:22 UTC) #2
jochen (gone - plz use gerrit)
6 years, 9 months ago (2014-03-28 08:59:33 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20323 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698