src/date.cc - Issue 216613003: Don't crash if we get a timezone change notification on an uninitialized isolate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/date.cc

Issue 216613003: Don't crash if we get a timezone change notification on an uninitialized isolate (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 6 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/date.cc

diff --git a/src/date.cc b/src/date.cc

index 70d6be989f0509f196cff01450be560fc738e74e..c22bc766734616671803fb30438a40e2ed1ebd7f 100644

--- a/src/date.cc

+++ b/src/date.cc

@@ -49,9 +49,10 @@ static const char kDaysInMonths[] =

void DateCache::ResetDateCache() {

static const int kMaxStamp = Smi::kMaxValue;

- stamp_ = Smi::FromInt(stamp_->value() + 1);

- if (stamp_->value() > kMaxStamp) {

+ if (stamp_->value() >= kMaxStamp) {

stamp_ = Smi::FromInt(0);

+ } else {

+ stamp_ = Smi::FromInt(stamp_->value() + 1);

}

ASSERT(stamp_ != Smi::FromInt(kInvalidStamp));

for (int i = 0; i < kDSTSize; ++i) {

« no previous file with comments | « src/api.cc ('k') | no next file » | no next file with comments »