Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(674)

Issue 2166043004: Create base class for web shell Earl Grey tests. (Closed)

Created:
4 years, 5 months ago by baxley
Modified:
4 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Create base class for web shell Earl Grey tests. Code to wait for shell to load and set up and tear down the http server can live here. BUG= Committed: https://crrev.com/62b505654f5459ac100c51b9ef3dfa746f3af2e8 Cr-Commit-Position: refs/heads/master@{#406984}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+59 lines, -49 lines) Patch
M ios/web/ios_web_shell_tests.gyp View 1 chunk +2 lines, -0 lines 0 comments Download
A ios/web/shell/test/earl_grey/shell_base_test_case.h View 1 chunk +15 lines, -0 lines 0 comments Download
A ios/web/shell/test/earl_grey/shell_base_test_case.mm View 1 chunk +37 lines, -0 lines 0 comments Download
M ios/web/shell/test/web_shell_navigation_egtest.mm View 1 chunk +2 lines, -28 lines 0 comments Download
M ios/web/shell/test/web_shell_page_state_egtest.mm View 2 chunks +3 lines, -21 lines 0 comments Download

Messages

Total messages: 12 (5 generated)
baxley
4 years, 5 months ago (2016-07-20 23:21:49 UTC) #2
Eugene But (OOO till 7-30)
lgtm
4 years, 5 months ago (2016-07-20 23:24:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166043004/1
4 years, 5 months ago (2016-07-21 00:28:28 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_ng/builds/266303)
4 years, 5 months ago (2016-07-21 02:05:01 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2166043004/1
4 years, 5 months ago (2016-07-21 22:25:01 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-21 23:10:18 UTC) #10
commit-bot: I haz the power
4 years, 5 months ago (2016-07-21 23:12:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/62b505654f5459ac100c51b9ef3dfa746f3af2e8
Cr-Commit-Position: refs/heads/master@{#406984}

Powered by Google App Engine
This is Rietveld 408576698