Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Unified Diff: ios/web/shell/test/web_shell_page_state_egtest.mm

Issue 2166043004: Create base class for web shell Earl Grey tests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/shell/test/web_shell_navigation_egtest.mm ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/shell/test/web_shell_page_state_egtest.mm
diff --git a/ios/web/shell/test/web_shell_page_state_egtest.mm b/ios/web/shell/test/web_shell_page_state_egtest.mm
index 952ad7e0a3f5ef570d943e90e5a7a86f0fbab346..4e6a09613992236fd576c9b670ef75d2dc8b38bf 100644
--- a/ios/web/shell/test/web_shell_page_state_egtest.mm
+++ b/ios/web/shell/test/web_shell_page_state_egtest.mm
@@ -10,6 +10,7 @@
#import "ios/web/public/test/http_server.h"
#include "ios/web/public/test/http_server_util.h"
#include "ios/web/shell/test/app/navigation_test_util.h"
+#import "ios/web/shell/test/earl_grey/shell_base_test_case.h"
#import "ios/web/shell/test/earl_grey/shell_matchers.h"
#if !defined(__has_feature) || !__has_feature(objc_arc)
@@ -51,31 +52,12 @@ using web::test::HttpServer;
using web::webViewContainingText;
// Page state test cases for the web shell.
-@interface CRWWebShellPageStateTest : XCTestCase
+@interface CRWWebShellPageStateTest : ShellBaseTestCase
+
@end
@implementation CRWWebShellPageStateTest
-// Set up called once for the class.
-+ (void)setUp {
- [super setUp];
- [[EarlGrey selectElementWithMatcher:webViewContainingText("Chromium")]
- assertWithMatcher:grey_notNil()];
- HttpServer::GetSharedInstance().StartOrDie();
-}
-
-// Tear down called once for the class.
-+ (void)tearDown {
- [super tearDown];
- HttpServer::GetSharedInstance().Stop();
-}
-
-// Tear down called after each test.
-- (void)tearDown {
- [super tearDown];
- HttpServer::GetSharedInstance().RemoveAllResponseProviders();
-}
-
// Tests that page scroll position of a page is restored upon returning to the
// page via the back/forward buttons.
- (void)testScrollPositionRestoring {
« no previous file with comments | « ios/web/shell/test/web_shell_navigation_egtest.mm ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698