mash: Migrate ShelfLockingManager to ash/common.

mash: Migrate ShelfLockingManager to ash/common.

tools/git/move_source_file.py ash/wm/lock_state_observer.h ash/common/wm/
tools/git/move_source_file.py ash/shelf/shelf_locking_manager* ash/common/shelf/

Move LockStateObservers and OnLockStateEvent helper to WmShell temporarily.
(to avoid converting LockStateController to ash/common for now)

Move ShelfLockingManager test access to Shelf/WmShelf.

BUG=629254
TEST=Automated tests; no behavior changes.
R=jamescook@chromium.org
TBR=piman@chromium.org

Committed: https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7
Cr-Commit-Position: refs/heads/master@{#406671}

[msw, 2016-07-20 19:41:13]

Description was changed from

==========
mash: Migrate ShelfLockingManager to ash/common.

BUG=629254
TEST=Automated tests; no behavior changes.
R=jamescook@chromium.org
==========

to

==========
mash: Migrate ShelfLockingManager to ash/common.

BUG=629254
TEST=Automated tests; no behavior changes.
R=jamescook@chromium.org
TBR=piman@chromium.org
==========

[msw, 2016-07-20 19:41:13]

msw@chromium.org changed reviewers:
+ piman@chromium.org

[msw, 2016-07-20 19:42:28]

Description was changed from

==========
mash: Migrate ShelfLockingManager to ash/common.

BUG=629254
TEST=Automated tests; no behavior changes.
R=jamescook@chromium.org
TBR=piman@chromium.org
==========

to

==========
mash: Migrate ShelfLockingManager to ash/common.

tools/git/move_source_file.py ash/wm/lock_state_observer.h ash/common/wm/
tools/git/move_source_file.py ash/shelf/shelf_locking_manager* ash/common/shelf/

Move LockStateObservers and OnLockStateEvent helper to WmShell temporarily.
(to avoid converting LockStateController to ash/common for now)

Add (temporary?) WmShelf::GetShelfLockingManagerForTesting.

BUG=629254
TEST=Automated tests; no behavior changes.
R=jamescook@chromium.org
==========

[msw, 2016-07-20 19:42:28]

msw@chromium.org changed reviewers:
- piman@chromium.org

[msw, 2016-07-20 19:42:53]

Description was changed from

==========
mash: Migrate ShelfLockingManager to ash/common.

tools/git/move_source_file.py ash/wm/lock_state_observer.h ash/common/wm/
tools/git/move_source_file.py ash/shelf/shelf_locking_manager* ash/common/shelf/

Move LockStateObservers and OnLockStateEvent helper to WmShell temporarily.
(to avoid converting LockStateController to ash/common for now)

Add (temporary?) WmShelf::GetShelfLockingManagerForTesting.

BUG=629254
TEST=Automated tests; no behavior changes.
R=jamescook@chromium.org
==========

to

==========
mash: Migrate ShelfLockingManager to ash/common.

tools/git/move_source_file.py ash/wm/lock_state_observer.h ash/common/wm/
tools/git/move_source_file.py ash/shelf/shelf_locking_manager* ash/common/shelf/

Move LockStateObservers and OnLockStateEvent helper to WmShell temporarily.
(to avoid converting LockStateController to ash/common for now)

Add (temporary?) WmShelf::GetShelfLockingManagerForTesting.

BUG=629254
TEST=Automated tests; no behavior changes.
R=jamescook@chromium.org
TBR=piman@chromium.org
==========

[msw, 2016-07-20 19:42:53]

msw@chromium.org changed reviewers:
+ piman@chromium.org

[msw, 2016-07-20 19:43:27]

Hey James, please take a look; thanks!
+TBR piman@ for mechanical webui_screen_locker.* changes.

[msw, 2016-07-20 19:43:37]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 19:44:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 19:49:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 19:49:13]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)
  linux_chromium_chromeos_compile_dbg_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_clobber_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[msw, 2016-07-20 20:18:11]

Description was changed from

==========
mash: Migrate ShelfLockingManager to ash/common.

tools/git/move_source_file.py ash/wm/lock_state_observer.h ash/common/wm/
tools/git/move_source_file.py ash/shelf/shelf_locking_manager* ash/common/shelf/

Move LockStateObservers and OnLockStateEvent helper to WmShell temporarily.
(to avoid converting LockStateController to ash/common for now)

Add (temporary?) WmShelf::GetShelfLockingManagerForTesting.

BUG=629254
TEST=Automated tests; no behavior changes.
R=jamescook@chromium.org
TBR=piman@chromium.org
==========

to

==========
mash: Migrate ShelfLockingManager to ash/common.

tools/git/move_source_file.py ash/wm/lock_state_observer.h ash/common/wm/
tools/git/move_source_file.py ash/shelf/shelf_locking_manager* ash/common/shelf/

Move LockStateObservers and OnLockStateEvent helper to WmShell temporarily.
(to avoid converting LockStateController to ash/common for now)

Move ShelfLockingManager test access to Shelf/WmShelf.

BUG=629254
TEST=Automated tests; no behavior changes.
R=jamescook@chromium.org
TBR=piman@chromium.org
==========

[msw, 2016-07-20 20:18:17]

The CQ bit was checked by msw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-07-20 20:18:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 21:03:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-07-20 21:03:35]

Dry run: This issue passed the CQ dry run.

[James Cook, 2016-07-20 21:14:30]

LGTM

https://codereview.chromium.org/2166043003/diff/40001/ash/common/shelf/shelf_...
File ash/common/shelf/shelf_locking_manager_unittest.cc (right):

https://codereview.chromium.org/2166043003/diff/40001/ash/common/shelf/shelf_...
ash/common/shelf/shelf_locking_manager_unittest.cc:82: }  // namespace ash
woo hoo, you were able to convert the test!

https://codereview.chromium.org/2166043003/diff/40001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2166043003/diff/40001/ash/common/wm_shell.h#n...
ash/common/wm_shell.h:229: // TODO: Move these back to LockStateController when
that has been moved.
nit: TODO(someone) -- the linter barfs on todo formats :-(

[msw, 2016-07-20 21:21:14]

https://codereview.chromium.org/2166043003/diff/40001/ash/common/shelf/shelf_...
File ash/common/shelf/shelf_locking_manager_unittest.cc (right):

https://codereview.chromium.org/2166043003/diff/40001/ash/common/shelf/shelf_...
ash/common/shelf/shelf_locking_manager_unittest.cc:82: }  // namespace ash
On 2016/07/20 21:14:30, James Cook wrote:
> woo hoo, you were able to convert the test!

Acknowledged.

https://codereview.chromium.org/2166043003/diff/40001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2166043003/diff/40001/ash/common/wm_shell.h#n...
ash/common/wm_shell.h:229: // TODO: Move these back to LockStateController when
that has been moved.
On 2016/07/20 21:14:30, James Cook wrote:
> nit: TODO(someone) -- the linter barfs on todo formats :-(

Eh, I'm okay with lint warnings here, unless you object further. Claiming
responsibility for every TODO in this migration project isn't entirely
reasonable; I expect some might hang out longer than we'll hope. Neither of us
have signed up to convert LockStateController, so it doesn't seem obligatory to
stamp my name on this followup task.

[msw, 2016-07-20 21:21:22]

The CQ bit was checked by msw@chromium.org

[commit-bot: I haz the power, 2016-07-20 21:21:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[James Cook, 2016-07-20 21:23:25]

still lgtm, land it!

https://codereview.chromium.org/2166043003/diff/40001/ash/common/wm_shell.h
File ash/common/wm_shell.h (right):

https://codereview.chromium.org/2166043003/diff/40001/ash/common/wm_shell.h#n...
ash/common/wm_shell.h:229: // TODO: Move these back to LockStateController when
that has been moved.
On 2016/07/20 21:21:14, msw wrote:
> On 2016/07/20 21:14:30, James Cook wrote:
> > nit: TODO(someone) -- the linter barfs on todo formats :-(
> 
> Eh, I'm okay with lint warnings here, unless you object further. Claiming
> responsibility for every TODO in this migration project isn't entirely
> reasonable; I expect some might hang out longer than we'll hope. Neither of us
> have signed up to convert LockStateController, so it doesn't seem obligatory
to
> stamp my name on this followup task.

Sure, leave it as-is, especially since you have green try runs.

In the future, maybe we should just use TODO(mustash) or something, following
https://google.github.io/styleguide/cppguide.html#TODO_Comments

[commit-bot: I haz the power, 2016-07-20 21:26:59]

Description was changed from

==========
mash: Migrate ShelfLockingManager to ash/common.

tools/git/move_source_file.py ash/wm/lock_state_observer.h ash/common/wm/
tools/git/move_source_file.py ash/shelf/shelf_locking_manager* ash/common/shelf/

Move LockStateObservers and OnLockStateEvent helper to WmShell temporarily.
(to avoid converting LockStateController to ash/common for now)

Move ShelfLockingManager test access to Shelf/WmShelf.

BUG=629254
TEST=Automated tests; no behavior changes.
R=jamescook@chromium.org
TBR=piman@chromium.org
==========

to

==========
mash: Migrate ShelfLockingManager to ash/common.

tools/git/move_source_file.py ash/wm/lock_state_observer.h ash/common/wm/
tools/git/move_source_file.py ash/shelf/shelf_locking_manager* ash/common/shelf/

Move LockStateObservers and OnLockStateEvent helper to WmShell temporarily.
(to avoid converting LockStateController to ash/common for now)

Move ShelfLockingManager test access to Shelf/WmShelf.

BUG=629254
TEST=Automated tests; no behavior changes.
R=jamescook@chromium.org
TBR=piman@chromium.org
==========

[commit-bot: I haz the power, 2016-07-20 21:27:00]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-07-20 21:30:08]

Description was changed from

==========
mash: Migrate ShelfLockingManager to ash/common.

tools/git/move_source_file.py ash/wm/lock_state_observer.h ash/common/wm/
tools/git/move_source_file.py ash/shelf/shelf_locking_manager* ash/common/shelf/

Move LockStateObservers and OnLockStateEvent helper to WmShell temporarily.
(to avoid converting LockStateController to ash/common for now)

Move ShelfLockingManager test access to Shelf/WmShelf.

BUG=629254
TEST=Automated tests; no behavior changes.
R=jamescook@chromium.org
TBR=piman@chromium.org
==========

to

==========
mash: Migrate ShelfLockingManager to ash/common.

tools/git/move_source_file.py ash/wm/lock_state_observer.h ash/common/wm/
tools/git/move_source_file.py ash/shelf/shelf_locking_manager* ash/common/shelf/

Move LockStateObservers and OnLockStateEvent helper to WmShell temporarily.
(to avoid converting LockStateController to ash/common for now)

Move ShelfLockingManager test access to Shelf/WmShelf.

BUG=629254
TEST=Automated tests; no behavior changes.
R=jamescook@chromium.org
TBR=piman@chromium.org

Committed: https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7
Cr-Commit-Position: refs/heads/master@{#406671}
==========

[commit-bot: I haz the power, 2016-07-20 21:30:09]

Patchset 3 (id:??) landed as
https://crrev.com/a0afa16d52f12081bbc2a780d2fef2943ff34cd7
Cr-Commit-Position: refs/heads/master@{#406671}