Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: public/platform/WebGraphicsContext3D.h

Issue 216603004: Fix WebGLDebugShaders::getTranslatedShaderSource returning null (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/graphics/test/MockWebGraphicsContext3D.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebGraphicsContext3D.h
diff --git a/public/platform/WebGraphicsContext3D.h b/public/platform/WebGraphicsContext3D.h
index 668164727b438a78bb5a420f3b72c4849c3ce20e..c0b08c9daed57127efdd8a684824d592fe455b38 100644
--- a/public/platform/WebGraphicsContext3D.h
+++ b/public/platform/WebGraphicsContext3D.h
@@ -391,9 +391,7 @@ public:
// state is sticky, rather than reported only once.
virtual WGC3Denum getGraphicsResetStatusARB() { return 0; /* GL_NO_ERROR */ }
- // FIXME: make this function pure virtual once it is implemented in
- // both command buffer port and in-process port.
- virtual WebString getTranslatedShaderSourceANGLE(WebGLId shader) { return WebString(); }
+ virtual WebString getTranslatedShaderSourceANGLE(WebGLId shader) = 0;
// GL_CHROMIUM_iosurface
virtual void texImageIOSurface2DCHROMIUM(WGC3Denum target, WGC3Dint width, WGC3Dint height, WGC3Duint ioSurfaceId, WGC3Duint plane) { }
« no previous file with comments | « Source/platform/graphics/test/MockWebGraphicsContext3D.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698