Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 216603004: Fix WebGLDebugShaders::getTranslatedShaderSource returning null (Closed)

Created:
6 years, 8 months ago by oetuaho-nv
Modified:
6 years, 8 months ago
CC:
blink-reviews, jamesr, krit, dsinclair, jbroman, abarth-chromium, danakj, dglazkov+blink, Rik, adamk+blink_chromium.org, Stephen Chennney, aandrey+blink_chromium.org, pdr., rwlbuis, bajones, Zhenyao Mo
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Fix WebGLDebugShaders::getTranslatedShaderSource returning null The function should return an empty string in case no source has been defined, compileShader() has not been called, or the translation has failed for shader. It used to return null, after this patch it returns an empty string like it is supposed to. Also make getTranslatedShaderSourceANGLE pure virtual in WebGraphicsContext3D. BUG=358530 TEST=WebGL conformance tests with --enable-privileged-webgl-extensions R=kbr@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170645

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M Source/core/html/canvas/WebGLDebugShaders.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/platform/graphics/test/MockWebGraphicsContext3D.h View 1 chunk +2 lines, -0 lines 0 comments Download
M public/platform/WebGraphicsContext3D.h View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
oetuaho-nv
Messaged chrome-troopers about the bot failures, they look unrelated.
6 years, 8 months ago (2014-04-01 09:11:40 UTC) #1
Ken Russell (switch to Gerrit)
Thanks for the fix. LGTM
6 years, 8 months ago (2014-04-01 22:50:52 UTC) #2
oetuaho-nv
The CQ bit was checked by oetuaho@nvidia.com
6 years, 8 months ago (2014-04-02 07:34:58 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oetuaho@nvidia.com/216603004/1
6 years, 8 months ago (2014-04-02 07:35:09 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 07:47:21 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on blink_presubmit
6 years, 8 months ago (2014-04-02 07:47:21 UTC) #6
oetuaho-nv
Adding some folks from public/OWNERS, please review.
6 years, 8 months ago (2014-04-02 08:01:09 UTC) #7
jochen (gone - plz use gerrit)
lgtm
6 years, 8 months ago (2014-04-02 09:22:36 UTC) #8
oetuaho-nv
The CQ bit was checked by oetuaho@nvidia.com
6 years, 8 months ago (2014-04-02 09:59:17 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/oetuaho@nvidia.com/216603004/1
6 years, 8 months ago (2014-04-02 09:59:24 UTC) #10
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 10:08:17 UTC) #11
Message was sent while issue was closed.
Change committed as 170645

Powered by Google App Engine
This is Rietveld 408576698