Issue 2166003: Merge 46700 - Don't bother returning the directory descriptor for SQLite....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2166003: Merge 46700 - Don't bother returning the directory descriptor for SQLite.... (Closed)

Created:
10 years, 7 months ago by inferno

Modified:
9 years, 7 months ago

Reviewers:
agl

CC:
chromium-reviews, jam+cc_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/375/src/

Visibility:
Public.

Description

Merge 46700 - Don't bother returning the directory descriptor for SQLite. (Reviewed by dumi.) TBR=agl@chromium.org BUG=43304 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48057

Patch Set 1 #

Created: 10 years, 7 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	chrome/browser/renderer_host/database_dispatcher_host.cc	View		1 chunk	+6 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

willchan no longer on Chromium

10 years, 7 months ago (2010-05-24 18:18:19 UTC) #3

Happened to see this diff as it scrolled by.  Doesn't close() have to
be HANDLE_EINTR() guarded?

On Mon, May 24, 2010 at 11:16 AM,  <agl@chromium.org> wrote:
> LGTM
>
> http://codereview.chromium.org/2166003/show
>

Expand Messages | Collapse Messages