Chromium Code Reviews
Help | Chromium Project | Sign in
(752)

Issue 2166003: Merge 46700 - Don't bother returning the directory descriptor for SQLite.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
3 years, 11 months ago by inferno
Modified:
2 years, 11 months ago
Reviewers:
agl
CC:
chromium-reviews_chromium.org, jam+cc_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Merge 46700 - Don't bother returning the directory descriptor for SQLite.

(Reviewed by dumi.)

TBR=agl@chromium.org
BUG=43304
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48057

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Lint Patch
M chrome/browser/renderer_host/database_dispatcher_host.cc View 1 chunk +6 lines, -0 lines 0 comments 0 errors Download
Trybot results:
Commit:

Messages

Total messages: 3
inferno
3 years, 11 months ago #1
agl
LGTM
3 years, 11 months ago #2
willchan
3 years, 11 months ago #3
Happened to see this diff as it scrolled by.  Doesn't close() have to
be HANDLE_EINTR() guarded?

On Mon, May 24, 2010 at 11:16 AM,  <agl@chromium.org> wrote:
> LGTM
>
> http://codereview.chromium.org/2166003/show
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1280:2d3e6564b7b6