Chromium Code Reviews
Help | Chromium Project | Sign in
(31)

Issue 2166003: Merge 46700 - Don't bother returning the directory descriptor for SQLite.... (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
5 years, 1 month ago by inferno
Modified:
4 years, 2 months ago
Reviewers:
agl
CC:
chromium-reviews, jam+cc_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org
Visibility:
Public.

Description

Merge 46700 - Don't bother returning the directory descriptor for SQLite. (Reviewed by dumi.) TBR=agl@chromium.org BUG=43304 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=48057

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/browser/renderer_host/database_dispatcher_host.cc View 1 chunk +6 lines, -0 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
inferno
5 years, 1 month ago (2010-05-24 18:15:41 UTC) #1
agl
LGTM
5 years, 1 month ago (2010-05-24 18:16:14 UTC) #2
willchan no longer on Chromium
5 years, 1 month ago (2010-05-24 18:18:19 UTC) #3
Happened to see this diff as it scrolled by.  Doesn't close() have to
be HANDLE_EINTR() guarded?

On Mon, May 24, 2010 at 11:16 AM,  <agl@chromium.org> wrote:
> LGTM
>
> http://codereview.chromium.org/2166003/show
>
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 2cec24f