Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(629)

Issue 2165983002: [NTP Snippets] Replace the "DisableSnippets" pref by an "Enable" one (Closed)

Created:
4 years, 5 months ago by Marc Treib
Modified:
4 years, 5 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Replace the "DisableSnippets" pref by an "Enable" one Follow-up to https://codereview.chromium.org/2158373002/ Turns out that new policies are supposed to be positive, so the pref should be too (otherwise we couldn't have the trivial policy->pref mapping). And anyway, a positive pref is probably nicer in any case. BUG=595713 Committed: https://crrev.com/b11f6447f0922841aa2da69fcb1edabec2a928bb Cr-Commit-Position: refs/heads/master@{#406601}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -7 lines) Patch
M components/ntp_snippets/ntp_snippets_status_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_status_service_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/ntp_snippets/pref_names.h View 1 chunk +1 line, -1 line 0 comments Download
M components/ntp_snippets/pref_names.cc View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (3 generated)
Marc Treib
4 years, 5 months ago (2016-07-20 15:15:22 UTC) #2
Bernhard Bauer
lgtm
4 years, 5 months ago (2016-07-20 15:17:56 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165983002/1
4 years, 5 months ago (2016-07-20 16:16:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 17:32:56 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-20 17:33:00 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 17:34:55 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b11f6447f0922841aa2da69fcb1edabec2a928bb
Cr-Commit-Position: refs/heads/master@{#406601}

Powered by Google App Engine
This is Rietveld 408576698