Introduce an NTPContentSuggestionsEnabled policy

Introduce an NTPContentSuggestionsEnabled policy

It directly maps to ntp_snippets::prefs::kEnableSnippets

BUG=595713
Committed: https://crrev.com/0a637476653089acc0a8df6ee9ea4126f8631d0b
Cr-Commit-Position: refs/heads/master@{#409027}

[Marc Treib, 2016-07-20 16:57:32]

Description was changed from

==========
Introduce a NTPContentSuggestionsEnabled policy

BUG=595713
==========

to

==========
Introduce an NTPContentSuggestionsEnabled policy

It directly maps to ntp_snippets::prefs::kEnableSnippets

BUG=595713
==========

[Marc Treib, 2016-07-29 10:26:42]

treib@chromium.org changed reviewers:
+ tnagel@chromium.org

[Marc Treib, 2016-07-29 10:26:43]

PTAL!

[Thiemo Nagel, 2016-07-29 16:10:46]

https://codereview.chromium.org/2162413002/diff/20001/chrome/browser/policy/c...
File chrome/browser/policy/configuration_policy_handler_list_factory.cc (right):

https://codereview.chromium.org/2162413002/diff/20001/chrome/browser/policy/c...
chrome/browser/policy/configuration_policy_handler_list_factory.cc:582: {
key::kNTPContentSuggestionsEnabled,
Nit: Please move above to join the rest of the non-#ifdef'ed policies.

https://codereview.chromium.org/2162413002/diff/20001/components/policy/resou...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/2162413002/diff/20001/components/policy/resou...
components/policy/resources/policy_templates.json:8788: '''If this is set to
true or not set, the New Tab page may show content suggestions based on the
user’s browsing history or interests.
Please use ' instead of ’.

Does the content not depend on location as well?

https://codereview.chromium.org/2162413002/diff/20001/components/policy/resou...
components/policy/resources/policy_templates.json:8790: If this is set to false,
no automatically-generated content suggestions will be shown on the New Tab
page.''',
In my opinion present tense is better style.

[Marc Treib, 2016-08-01 08:20:13]

https://codereview.chromium.org/2162413002/diff/20001/chrome/browser/policy/c...
File chrome/browser/policy/configuration_policy_handler_list_factory.cc (right):

https://codereview.chromium.org/2162413002/diff/20001/chrome/browser/policy/c...
chrome/browser/policy/configuration_policy_handler_list_factory.cc:582: {
key::kNTPContentSuggestionsEnabled,
On 2016/07/29 16:10:46, Thiemo Nagel wrote:
> Nit: Please move above to join the rest of the non-#ifdef'ed policies.

Done.

https://codereview.chromium.org/2162413002/diff/20001/components/policy/resou...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/2162413002/diff/20001/components/policy/resou...
components/policy/resources/policy_templates.json:8788: '''If this is set to
true or not set, the New Tab page may show content suggestions based on the
user’s browsing history or interests.
On 2016/07/29 16:10:46, Thiemo Nagel wrote:
> Please use ' instead of ’.

Good eyes! Done.

> Does the content not depend on location as well?

Not yet, though there are some plans to that effect, so might as well mention
that now. Done.

https://codereview.chromium.org/2162413002/diff/20001/components/policy/resou...
components/policy/resources/policy_templates.json:8790: If this is set to false,
no automatically-generated content suggestions will be shown on the New Tab
page.''',
On 2016/07/29 16:10:46, Thiemo Nagel wrote:
> In my opinion present tense is better style.

Done.

[Marc Treib, 2016-08-01 08:20:35]

treib@chromium.org changed reviewers:
+ isherman@chromium.org

[Marc Treib, 2016-08-01 08:20:36]

+isherman for histograms.xml. PTAL!

[Thiemo Nagel, 2016-08-01 09:23:26]

lgtm

https://codereview.chromium.org/2162413002/diff/40001/components/policy/resou...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/2162413002/diff/40001/components/policy/resou...
components/policy/resources/policy_templates.json:8794: If this is set to false,
no automatically-generated content suggestions are shown on the New Tab
page.''',
optional nit: "no ... suggestions are shown" --> "suggestions are not shown"

[Marc Treib, 2016-08-01 10:30:51]

https://codereview.chromium.org/2162413002/diff/40001/components/policy/resou...
File components/policy/resources/policy_templates.json (right):

https://codereview.chromium.org/2162413002/diff/40001/components/policy/resou...
components/policy/resources/policy_templates.json:8794: If this is set to false,
no automatically-generated content suggestions are shown on the New Tab
page.''',
On 2016/08/01 09:23:25, Thiemo Nagel wrote:
> optional nit: "no ... suggestions are shown" --> "suggestions are not shown"

Done.

[Ilya Sherman, 2016-08-01 18:07:29]

histograms.xml lgtm

[Ilya Sherman, 2016-08-01 18:07:55]

The CQ bit was checked by isherman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-01 18:08:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 19:17:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-01 19:17:39]

Dry run: This issue passed the CQ dry run.

[Marc Treib, 2016-08-01 19:28:05]

The CQ bit was checked by treib@chromium.org

[Marc Treib, 2016-08-01 19:28:06]

The patchset sent to the CQ was uploaded after l-g-t-m from tnagel@chromium.org
Link to the patchset: https://codereview.chromium.org/2162413002/#ps60001
(title: "nit")

[commit-bot: I haz the power, 2016-08-01 19:29:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-01 19:33:41]

Description was changed from

==========
Introduce an NTPContentSuggestionsEnabled policy

It directly maps to ntp_snippets::prefs::kEnableSnippets

BUG=595713
==========

to

==========
Introduce an NTPContentSuggestionsEnabled policy

It directly maps to ntp_snippets::prefs::kEnableSnippets

BUG=595713
==========

[commit-bot: I haz the power, 2016-08-01 19:33:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-08-01 19:37:32]

Description was changed from

==========
Introduce an NTPContentSuggestionsEnabled policy

It directly maps to ntp_snippets::prefs::kEnableSnippets

BUG=595713
==========

to

==========
Introduce an NTPContentSuggestionsEnabled policy

It directly maps to ntp_snippets::prefs::kEnableSnippets

BUG=595713

Committed: https://crrev.com/0a637476653089acc0a8df6ee9ea4126f8631d0b
Cr-Commit-Position: refs/heads/master@{#409027}
==========

[commit-bot: I haz the power, 2016-08-01 19:37:34]

Patchset 4 (id:??) landed as
https://crrev.com/0a637476653089acc0a8df6ee9ea4126f8631d0b
Cr-Commit-Position: refs/heads/master@{#409027}