Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(382)

Issue 2165923002: Inline Scope::Initialize into the only constructor that's always called right before (Closed)

Created:
4 years, 5 months ago by Toon Verwaest
Modified:
4 years, 5 months ago
Reviewers:
rossberg, marja
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Inline Scope::Initialize into the only constructor that's always called right before This additionally makes the invariant obvious that outer_scope==nullptr+is_with_scope is impossible. BUG=v8:5209 Committed: https://crrev.com/13cbf545223a3166bd8c7d72c2abac4425a0a4a1 Cr-Commit-Position: refs/heads/master@{#37902}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -20 lines) Patch
M src/ast/scopes.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/ast/scopes.cc View 2 chunks +7 lines, -15 lines 0 comments Download
M src/parsing/parser-base.h View 2 chunks +0 lines, -2 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
Toon Verwaest
ptal (rossberg as ast owner, since I'm still not an ast owner myself ... :))
4 years, 5 months ago (2016-07-20 07:55:49 UTC) #2
marja
lgtm % spelling mistake in the description: invariant
4 years, 5 months ago (2016-07-20 08:50:01 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165923002/1
4 years, 5 months ago (2016-07-20 11:14:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-20 12:16:54 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-20 12:19:57 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/13cbf545223a3166bd8c7d72c2abac4425a0a4a1
Cr-Commit-Position: refs/heads/master@{#37902}

Powered by Google App Engine
This is Rietveld 408576698