Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(113)

Unified Diff: src/parsing/parser-base.h

Issue 2165923002: Inline Scope::Initialize into the only constructor that's always called right before (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/ast/scopes.cc ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/parsing/parser-base.h
diff --git a/src/parsing/parser-base.h b/src/parsing/parser-base.h
index b6cf8218e56daf14a554ff82e750d7dcf40d7508..881155577801b70d03ca99fe76cb1394409c128c 100644
--- a/src/parsing/parser-base.h
+++ b/src/parsing/parser-base.h
@@ -620,7 +620,6 @@ class ParserBase : public Traits {
DCHECK(scope_type != FUNCTION_SCOPE);
Scope* result =
new (zone()) Scope(zone(), parent, scope_type, kNormalFunction);
- result->Initialize();
if (scope_type == MODULE_SCOPE) result->DeclareThis(ast_value_factory());
return result;
}
@@ -628,7 +627,6 @@ class ParserBase : public Traits {
Scope* NewFunctionScope(FunctionKind kind) {
DCHECK(ast_value_factory());
Scope* result = new (zone()) Scope(zone(), scope(), FUNCTION_SCOPE, kind);
- result->Initialize();
if (!IsArrowFunction(kind)) {
result->DeclareThis(ast_value_factory());
result->DeclareDefaultFunctionVariables(ast_value_factory());
« no previous file with comments | « src/ast/scopes.cc ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698