Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2165913004: Converted Observatory class-nav-menu element (Closed)

Created:
4 years, 5 months ago by cbernaschina
Modified:
4 years, 5 months ago
Reviewers:
turnidge, rmacnak, Cutch
CC:
reviews_dartlang.org, turnidge, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added missing files to observatory_sources.gypi #

Patch Set 3 : Mock objects can be const #

Patch Set 4 : Adding _getBoolAttribute helper method #

Patch Set 5 : Fixed typo #

Total comments: 3

Patch Set 6 : Marged with master #

Patch Set 7 : Marged with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+135 lines, -62 lines) Patch
M runtime/observatory/lib/elements.dart View 1 2 3 4 5 6 3 chunks +5 lines, -0 lines 0 comments Download
M runtime/observatory/lib/mocks.dart View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
M runtime/observatory/lib/models.dart View 1 2 3 4 5 6 1 chunk +1 line, -0 lines 0 comments Download
A + runtime/observatory/lib/src/elements/nav/class_menu.dart View 1 2 3 4 5 2 chunks +20 lines, -16 lines 0 comments Download
A + runtime/observatory/lib/src/elements/nav/class_menu_wrapper.dart View 1 2 3 4 5 2 chunks +14 lines, -21 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav_bar.dart View 1 2 3 4 5 6 1 chunk +0 lines, -8 lines 0 comments Download
M runtime/observatory/lib/src/elements/nav_bar.html View 1 2 3 4 5 6 1 chunk +0 lines, -9 lines 0 comments Download
A runtime/observatory/lib/src/mocks/objects/class.dart View 1 2 4 1 chunk +22 lines, -0 lines 0 comments Download
A runtime/observatory/lib/src/models/objects/class.dart View 4 1 chunk +57 lines, -0 lines 0 comments Download
M runtime/observatory/lib/src/service/object.dart View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M runtime/observatory/observatory_sources.gypi View 1 2 3 4 5 6 2 chunks +4 lines, -0 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/nav/class-menu/element_test.dart View 1 2 3 4 5 1 chunk +11 lines, -8 lines 0 comments Download
A + runtime/observatory/tests/observatory_ui/nav/class-menu/element_test.html View 4 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 15 (2 generated)
cbernaschina
4 years, 5 months ago (2016-07-20 20:45:46 UTC) #2
Cutch
https://codereview.chromium.org/2165913004/diff/1/runtime/observatory/lib/src/elements/nav/class_menu.dart File runtime/observatory/lib/src/elements/nav/class_menu.dart (right): https://codereview.chromium.org/2165913004/diff/1/runtime/observatory/lib/src/elements/nav/class_menu.dart#newcode59 runtime/observatory/lib/src/elements/nav/class_menu.dart:59: link: new Uri(path: '/inspect', I'm starting to think this ...
4 years, 5 months ago (2016-07-20 21:11:17 UTC) #3
cbernaschina
4 years, 5 months ago (2016-07-20 21:53:49 UTC) #4
cbernaschina
https://codereview.chromium.org/2165913004/diff/1/runtime/observatory/lib/src/elements/nav/class_menu.dart File runtime/observatory/lib/src/elements/nav/class_menu.dart (right): https://codereview.chromium.org/2165913004/diff/1/runtime/observatory/lib/src/elements/nav/class_menu.dart#newcode59 runtime/observatory/lib/src/elements/nav/class_menu.dart:59: link: new Uri(path: '/inspect', On 2016/07/20 21:11:16, Cutch wrote: ...
4 years, 5 months ago (2016-07-20 22:38:42 UTC) #5
cbernaschina
4 years, 5 months ago (2016-07-21 01:02:58 UTC) #6
cbernaschina
4 years, 5 months ago (2016-07-21 18:26:07 UTC) #7
cbernaschina
4 years, 5 months ago (2016-07-21 18:29:09 UTC) #8
Cutch
LGTM after fixing the Uri construction. https://codereview.chromium.org/2165913004/diff/80001/runtime/observatory/lib/src/elements/nav/class_menu.dart File runtime/observatory/lib/src/elements/nav/class_menu.dart (right): https://codereview.chromium.org/2165913004/diff/80001/runtime/observatory/lib/src/elements/nav/class_menu.dart#newcode59 runtime/observatory/lib/src/elements/nav/class_menu.dart:59: link: new Uri(path: ...
4 years, 5 months ago (2016-07-22 13:31:43 UTC) #9
cbernaschina
https://codereview.chromium.org/2165913004/diff/80001/runtime/observatory/lib/src/elements/nav/class_menu.dart File runtime/observatory/lib/src/elements/nav/class_menu.dart (right): https://codereview.chromium.org/2165913004/diff/80001/runtime/observatory/lib/src/elements/nav/class_menu.dart#newcode59 runtime/observatory/lib/src/elements/nav/class_menu.dart:59: link: new Uri(path: '/inspect', On 2016/07/22 13:31:43, Cutch wrote: ...
4 years, 5 months ago (2016-07-22 16:57:54 UTC) #10
cbernaschina
https://codereview.chromium.org/2165913004/diff/80001/runtime/observatory/lib/src/elements/nav/class_menu.dart File runtime/observatory/lib/src/elements/nav/class_menu.dart (right): https://codereview.chromium.org/2165913004/diff/80001/runtime/observatory/lib/src/elements/nav/class_menu.dart#newcode59 runtime/observatory/lib/src/elements/nav/class_menu.dart:59: link: new Uri(path: '/inspect', On 2016/07/22 13:31:43, Cutch wrote: ...
4 years, 5 months ago (2016-07-22 21:52:44 UTC) #11
cbernaschina
4 years, 5 months ago (2016-07-22 23:33:40 UTC) #12
rmacnak
lgtm
4 years, 5 months ago (2016-07-23 00:11:16 UTC) #13
cbernaschina
4 years, 5 months ago (2016-07-23 00:22:58 UTC) #15
Message was sent while issue was closed. 
Committed patchset #7 (id:120001) manually as
a66cee26bdabe225f2bec7213538b3cb17506bc0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698