Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Unified Diff: runtime/observatory/lib/src/elements/nav/class_menu.dart

Issue 2165913004: Converted Observatory class-nav-menu element (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Marged with master Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/nav/class_menu.dart
diff --git a/runtime/observatory/lib/src/elements/nav/top_menu.dart b/runtime/observatory/lib/src/elements/nav/class_menu.dart
similarity index 50%
copy from runtime/observatory/lib/src/elements/nav/top_menu.dart
copy to runtime/observatory/lib/src/elements/nav/class_menu.dart
index a289277df186a16687cc188bbe8d17d2f5217874..d8ed510a8675655b54e80d9a4d9f2f0d45512fee 100644
--- a/runtime/observatory/lib/src/elements/nav/top_menu.dart
+++ b/runtime/observatory/lib/src/elements/nav/class_menu.dart
@@ -4,34 +4,42 @@
import 'dart:html';
import 'dart:async';
+import 'package:observatory/models.dart' as M show IsolateRef, ClassRef;
import 'package:observatory/src/elements/helpers/rendering_scheduler.dart';
import 'package:observatory/src/elements/helpers/tag.dart';
import 'package:observatory/src/elements/helpers/uris.dart';
import 'package:observatory/src/elements/nav/menu.dart';
-import 'package:observatory/src/elements/nav/menu_item.dart';
-class NavTopMenuElement extends HtmlElement implements Renderable {
- static const tag = const Tag<NavTopMenuElement>('nav-top-menu',
- dependencies: const [NavMenuElement.tag,
- NavMenuItemElement.tag]);
+class NavClassMenuElement extends HtmlElement implements Renderable {
+ static const tag = const Tag<NavClassMenuElement>('nav-class-menu',
+ dependencies: const [NavMenuElement.tag]);
RenderingScheduler _r;
- Stream<RenderedEvent<NavTopMenuElement>> get onRendered => _r.onRendered;
+ Stream<RenderedEvent<NavClassMenuElement>> get onRendered => _r.onRendered;
bool _last;
+ M.IsolateRef _isolate;
+ M.ClassRef _cls;
bool get last => _last;
+ M.IsolateRef get isolate => _isolate;
+ M.ClassRef get cls => _cls;
set last(bool value) => _last = _r.checkAndReact(_last, value);
- factory NavTopMenuElement({bool last: false, RenderingQueue queue}) {
+ factory NavClassMenuElement(M.IsolateRef isolate, M.ClassRef cls,
+ {bool last: false, RenderingQueue queue}) {
+ assert(isolate != null);
+ assert(cls != null);
assert(last != null);
- NavTopMenuElement e = document.createElement(tag.name);
+ NavClassMenuElement e = document.createElement(tag.name);
e._r = new RenderingScheduler(e, queue: queue);
+ e._isolate = isolate;
+ e._cls = cls;
e._last = last;
return e;
}
- NavTopMenuElement.created() : super.created() { createShadowRoot(); }
+ NavClassMenuElement.created() : super.created() { createShadowRoot(); }
@override
void attached() {
@@ -48,13 +56,9 @@ class NavTopMenuElement extends HtmlElement implements Renderable {
void render() {
shadowRoot.children = [
- new NavMenuElement('Observatory', link: Uris.vm(), last: last,
- queue: _r.queue)
- ..children = [
- new NavMenuItemElement('Connect to a VM', link: Uris.vmConnect(),
- queue: _r.queue),
- new ContentElement()
- ]
+ new NavMenuElement(cls.name, last: last, queue: _r.queue,
+ link: Uris.inspect(isolate, object: cls))
+ ..children = [new ContentElement()]
];
}
}
« no previous file with comments | « runtime/observatory/lib/models.dart ('k') | runtime/observatory/lib/src/elements/nav/class_menu_wrapper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698