Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 216583002: [fsp] Use types from another namespaces in IDL. (Closed)

Created:
6 years, 9 months ago by mtomasz
Modified:
6 years, 8 months ago
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

[fsp] Use types from another namespaces in IDL. Before, it wasn't possible to refer to types defined in another namespace/file. However CL 197873009 enables it, so there is no need to use string as a workaround for enum. TEST=unit_tests and browser_tests. BUG=248427, 158654 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263174

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -12 lines) Patch
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc View 1 chunk +1 line, -9 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider_internal.idl View 1 chunk +1 line, -3 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
mtomasz
This CL depends on 194693002. @hirono: PTAL. Thanks.
6 years, 8 months ago (2014-04-09 19:53:02 UTC) #1
hirono
lgtm!
6 years, 8 months ago (2014-04-09 19:55:18 UTC) #2
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 8 months ago (2014-04-09 23:09:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/216583002/1
6 years, 8 months ago (2014-04-09 23:10:23 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-09 23:50:11 UTC) #5
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=60508
6 years, 8 months ago (2014-04-09 23:50:12 UTC) #6
mtomasz
@kalman: PTAL at the IDL. It makes use of the recent patch allowing scoped types ...
6 years, 8 months ago (2014-04-10 21:25:11 UTC) #7
not at google - send to devlin
lgtm sweet!
6 years, 8 months ago (2014-04-10 21:26:27 UTC) #8
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 8 months ago (2014-04-10 21:27:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/216583002/1
6 years, 8 months ago (2014-04-10 21:27:48 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 23:38:28 UTC) #11
commit-bot: I haz the power
Retried try job too often on ios_dbg_simulator for step(s) base_unittests, compile, components_unittests, content_unittests, crypto_unittests, net_unittests, ...
6 years, 8 months ago (2014-04-10 23:38:29 UTC) #12
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 8 months ago (2014-04-10 23:50:11 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/216583002/1
6 years, 8 months ago (2014-04-10 23:50:42 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-11 03:16:18 UTC) #15
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) unit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=296019
6 years, 8 months ago (2014-04-11 03:16:19 UTC) #16
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 8 months ago (2014-04-11 03:58:39 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/216583002/1
6 years, 8 months ago (2014-04-11 03:58:57 UTC) #18
commit-bot: I haz the power
6 years, 8 months ago (2014-04-11 07:36:33 UTC) #19
Message was sent while issue was closed.
Change committed as 263174

Powered by Google App Engine
This is Rietveld 408576698