Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2063)

Unified Diff: chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc

Issue 216583002: [fsp] Use types from another namespaces in IDL. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/extensions/api/file_system_provider_internal.idl » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
diff --git a/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc b/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
index 29b08b26c0724829f2facb3b4ccf3618dd6a746d..471f7c3d0c0b8d03bc6d5358080adfc9d938bb25 100644
--- a/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
+++ b/chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_api.cc
@@ -183,18 +183,10 @@ bool FileSystemProviderInternalUnmountRequestedErrorFunction::RunImpl() {
chromeos::file_system_provider::Service::Get(GetProfile());
DCHECK(service);
- // Currently it is not possible to refer to types/enums defined in a different
- // IDL file. Therefore we need to convert DOMString to ProviderError, since
- // UnmountRequestedErrorFunction() is defined in a different namespace than
- // ProvidedError.
- // TODO(mtomasz): Remove this trick, once IDL supports namespaces correctly.
- const api::file_system_provider::ProviderError provider_error =
- api::file_system_provider::ParseProviderError(params->error);
-
if (!service->RejectRequest(extension_id(),
params->file_system_id,
params->request_id,
- ProviderErrorToFileError(provider_error))) {
+ ProviderErrorToFileError(params->error))) {
// TODO(mtomasz): Pass more detailed errors, rather than just a bool.
base::ListValue* result = new base::ListValue();
result->Append(
« no previous file with comments | « no previous file | chrome/common/extensions/api/file_system_provider_internal.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698