Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2165733002: Misc Chromedriver bot fixes. (Closed)

Created:
4 years, 5 months ago by mikecase (-- gone --)
Modified:
4 years, 5 months ago
Reviewers:
samuong, jbudorick
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Misc Chromedriver bot fixes. Fixes (1) bot run not showing up red when test fails (2) Chrome being wiped from the device. The Chrome builds have to be installed manually so these should not be wiped. (3) The "chrome_public" --android-package should be "chromium". BUG=627633 Committed: https://chromium.googlesource.com/chromium/tools/build/+/4ea6215bfc3a0c742a18bf4e9a7de37e86ea5187

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -47 lines) Patch
M scripts/slave/recipe_modules/chromium_android/api.py View 2 chunks +3 lines, -1 line 0 comments Download
M scripts/slave/recipes/chromedriver.py View 3 chunks +5 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__basic.json View 7 chunks +14 lines, -13 lines 0 comments Download
M scripts/slave/recipes/chromedriver.expected/Android_ChromeDriver_Tests__dbg__test_failure.json View 8 chunks +33 lines, -31 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
mikecase (-- gone --)
4 years, 5 months ago (2016-07-19 18:28:51 UTC) #2
jbudorick
lgtm
4 years, 5 months ago (2016-07-19 18:30:47 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165733002/1
4 years, 5 months ago (2016-07-19 18:35:36 UTC) #5
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 18:40:16 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/tools/build/+/4ea6215bfc3a0c742a18...

Powered by Google App Engine
This is Rietveld 408576698