Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Side by Side Diff: scripts/slave/recipes/chromedriver.py

Issue 2165733002: Misc Chromedriver bot fixes. (Closed) Base URL: https://chromium.googlesource.com/chromium/tools/build.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 from recipe_engine import recipe_api 5 from recipe_engine import recipe_api
6 from recipe_engine.types import freeze 6 from recipe_engine.types import freeze
7 7
8 DEPS = [ 8 DEPS = [
9 'adb', 9 'adb',
10 'archive', 10 'archive',
(...skipping 10 matching lines...) Expand all
21 21
22 BUILDERS = freeze({ 22 BUILDERS = freeze({
23 'chromium.fyi': { 23 'chromium.fyi': {
24 'Android ChromeDriver Tests (dbg)': { 24 'Android ChromeDriver Tests (dbg)': {
25 'chromedriver_platform': 'android', 25 'chromedriver_platform': 'android',
26 'config': 'main_builder', 26 'config': 'main_builder',
27 'target': 'Debug', 27 'target': 'Debug',
28 'update_test_log': True, 28 'update_test_log': True,
29 'android_packages': [ 29 'android_packages': [
30 'chrome_beta', 30 'chrome_beta',
31 'chrome_public',
32 'chrome_stable', 31 'chrome_stable',
33 'chromedriver_webview_shell', 32 'chromedriver_webview_shell',
33 'chromium',
34 ], 34 ],
35 'install_apks': [ 35 'install_apks': [
36 'ChromeDriverWebViewShell.apk', 36 'ChromeDriverWebViewShell.apk',
37 'ChromePublic.apk', 37 'ChromePublic.apk',
38 ], 38 ],
39 }, 39 },
40 }, 40 },
41 }) 41 })
42 42
43 REPO_URL = 'https://chromium.googlesource.com/chromium/src.git' 43 REPO_URL = 'https://chromium.googlesource.com/chromium/src.git'
(...skipping 20 matching lines...) Expand all
64 api.chromium_android.run_tree_truth() 64 api.chromium_android.run_tree_truth()
65 65
66 api.archive.download_and_unzip_build( 66 api.archive.download_and_unzip_build(
67 step_name='extract build', 67 step_name='extract build',
68 target=api.chromium.c.BUILD_CONFIG, 68 target=api.chromium.c.BUILD_CONFIG,
69 build_url=None, 69 build_url=None,
70 build_archive_url=api.properties.get('parent_build_archive_url')) 70 build_archive_url=api.properties.get('parent_build_archive_url'))
71 revision_cp = api.bot_update.last_returned_properties['got_revision_cp'] 71 revision_cp = api.bot_update.last_returned_properties['got_revision_cp']
72 commit_position = api.commit_position.parse_revision(revision_cp) 72 commit_position = api.commit_position.parse_revision(revision_cp)
73 73
74 api.chromium_android.common_tests_setup_steps() 74 api.chromium_android.common_tests_setup_steps(skip_wipe=True)
75 if builder['install_apks']: 75 if builder['install_apks']:
76 for apk in builder['install_apks']: 76 for apk in builder['install_apks']:
77 api.chromium_android.adb_install_apk(apk) 77 api.chromium_android.adb_install_apk(apk)
78 api.chromedriver.download_prebuilts() 78 api.chromedriver.download_prebuilts()
79 79
80 passed = True 80 passed = True
81 try: 81 try:
82 api.chromedriver.run_all_tests( 82 api.chromedriver.run_all_tests(
83 android_packages=android_packages, 83 android_packages=android_packages,
84 archive_server_logs=True) 84 archive_server_logs=True)
85 except api.step.StepFailure: 85 except api.step.StepFailure:
86 passed = False 86 passed = False
87 if update_test_log: 87 if update_test_log:
88 api.chromedriver.update_test_results_log(platform, commit_position, passed) 88 api.chromedriver.update_test_results_log(platform, commit_position, passed)
89 89
90 api.chromium_android.common_tests_final_steps() 90 api.chromium_android.common_tests_final_steps()
91 91
92 if not passed:
93 raise api.step.StepFailure('Test failures')
94
92 def GenTests(api): 95 def GenTests(api):
93 sanitize = lambda s: ''.join(c if c.isalnum() else '_' for c in s) 96 sanitize = lambda s: ''.join(c if c.isalnum() else '_' for c in s)
94 97
95 yield ( 98 yield (
96 api.test('%s_basic' % sanitize('Android ChromeDriver Tests (dbg)')) + 99 api.test('%s_basic' % sanitize('Android ChromeDriver Tests (dbg)')) +
97 api.properties.generic( 100 api.properties.generic(
98 buildername='Android ChromeDriver Tests (dbg)', 101 buildername='Android ChromeDriver Tests (dbg)',
99 slavename='slavename', 102 slavename='slavename',
100 mastername='chromium.fyi') + 103 mastername='chromium.fyi') +
101 api.properties( 104 api.properties(
102 parent_build_archive_url='gs://test-domain/test-archive.zip', 105 parent_build_archive_url='gs://test-domain/test-archive.zip',
103 got_revision='4f4b02f6b7fa20a3a25682c457bbc8ad589c8a00', 106 got_revision='4f4b02f6b7fa20a3a25682c457bbc8ad589c8a00',
104 got_revision_cp='refs/heads/master@{#333333}')) 107 got_revision_cp='refs/heads/master@{#333333}'))
105 108
106 yield ( 109 yield (
107 api.test( 110 api.test(
108 '%s_test_failure' % sanitize('Android ChromeDriver Tests (dbg)')) + 111 '%s_test_failure' % sanitize('Android ChromeDriver Tests (dbg)')) +
109 api.properties.generic( 112 api.properties.generic(
110 buildername='Android ChromeDriver Tests (dbg)', 113 buildername='Android ChromeDriver Tests (dbg)',
111 slavename='slavename', 114 slavename='slavename',
112 mastername='chromium.fyi') + 115 mastername='chromium.fyi') +
113 api.properties( 116 api.properties(
114 parent_build_archive_url='gs://test-domain/test-archive.zip', 117 parent_build_archive_url='gs://test-domain/test-archive.zip',
115 got_revision='4f4b02f6b7fa20a3a25682c457bbc8ad589c8a00', 118 got_revision='4f4b02f6b7fa20a3a25682c457bbc8ad589c8a00',
116 got_revision_cp='refs/heads/master@{#333333}') + 119 got_revision_cp='refs/heads/master@{#333333}') +
117 api.step_data('java_tests(chrome_stable)', retcode=1)) 120 api.step_data('java_tests(chrome_stable)', retcode=1))
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698