Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(235)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2165683002: Simplify random_draw_context used by GLProgramsTest (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Simplify random_draw_context used by GLProgramsTest GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165683002 Committed: https://skia.googlesource.com/skia/+/28b62e6672e59957fc9c5c85c87cb65d8bbb44df

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -21 lines) Patch
M tests/GLProgramsTest.cpp View 1 chunk +0 lines, -21 lines 1 comment Download

Messages

Total messages: 9 (5 generated)
bsalomon
https://codereview.chromium.org/2165683002/diff/1/tests/GLProgramsTest.cpp File tests/GLProgramsTest.cpp (left): https://codereview.chromium.org/2165683002/diff/1/tests/GLProgramsTest.cpp#oldcode157 tests/GLProgramsTest.cpp:157: GrUniqueKey key; I presume this keying was preserved from ...
4 years, 5 months ago (2016-07-19 15:04:29 UTC) #4
Brian Osman
lgtm
4 years, 5 months ago (2016-07-19 15:05:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165683002/1
4 years, 5 months ago (2016-07-19 15:13:17 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 15:38:07 UTC) #9
Message was sent while issue was closed. 
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/28b62e6672e59957fc9c5c85c87cb65d8bbb44df

Powered by Google App Engine
This is Rietveld 408576698