Issue 2165643005: Change PGO recipe to use MB now that it supports multiple phases.

Issue 2165643005: Change PGO recipe to use MB now that it supports multiple phases. (Closed)

Created:
4 years, 5 months ago by Dirk Pranke

Modified:
4 years, 5 months ago

Reviewers:
Sébastien Marchand

CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master

Target Ref:
refs/heads/master

Project:
build

Visibility:
Public.

More Reviews

Description

Change PGO recipe to use MB now that it supports multiple phases. R=sebmarchand@chromium.org BUG=595947 Committed: https://chromium.googlesource.com/chromium/tools/build/+/be09b8b990b15e9a6945a8a43aa9fead0c0f1457

Patch Set 1 #

Created: 4 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+150 lines, -49 lines)			Patch
M	scripts/slave/recipe_modules/chromium/api.py	View	3 chunks	+5 lines, -7 lines	0 comments	Download
M	scripts/slave/recipe_modules/pgo/api.py	View	2 chunks	+10 lines, -2 lines	0 comments	Download
M	scripts/slave/recipe_modules/pgo/example.expected/full_chromium_pgo_test_Test_builder.json	View	2 chunks	+27 lines, -8 lines	0 comments	Download
M	scripts/slave/recipe_modules/pgo/example.expected/full_chromium_pgo_test_Test_builder_benchmark_failure.json	View	2 chunks	+27 lines, -8 lines	0 comments	Download
M	scripts/slave/recipes/chromium_pgo.expected/full_chromium_fyi_Chromium_Win_PGO_Builder.json	View	2 chunks	+27 lines, -8 lines	0 comments	Download
M	scripts/slave/recipes/chromium_pgo.expected/full_chromium_fyi_Chromium_Win_x64_PGO_Builder.json	View	2 chunks	+27 lines, -8 lines	0 comments	Download
M	scripts/slave/recipes/chromium_pgo.expected/full_tryserver_chromium_win_win_pgo.json	View	2 chunks	+27 lines, -8 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Dirk Pranke

This needs https://codereview.chromium.org/2165643005 to land first, but once these two CLs land then you can ...

4 years, 5 months ago (2016-07-19 23:29:53 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165643005/1

4 years, 5 months ago (2016-07-22 16:17:52 UTC) #4

commit-bot: I haz the power

Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/tools/build/+/be09b8b990b15e9a6945a8a43aa9fead0c0f1457

4 years, 5 months ago (2016-07-22 16:21:10 UTC) #6

Dirk Pranke

4 years, 5 months ago (2016-07-23 00:39:36 UTC) #7

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2175063002/ by dpranke@chromium.org.

The reason for reverting is: breaks official builder, which doesn't find the MB
change on the older branches..

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages