Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Issue 2165583002: Reland 2: Android: Add support for TraceEvent before the native library is loaded. (patchset #2 id:… (Closed)

Created:
4 years, 5 months ago by Benoit L
Modified:
4 years, 5 months ago
Reviewers:
phoglund_chromium
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland 2 of: Android: Add support for TraceEvent before the native library is loaded. This is a revert of https://codereview.chromium.org/2142803002/ Initial commit description: Android: Add support for TraceEvent before the native library is loaded. Currently TraceEvents recorded before the native library load are silently discarded. This CL adds support for such "early" events. The events are buffered in Java, and then sent to the native side once it is available. This support is intentionally simple now. The aim is to ease performance investigation of early startup, and to ease tracking of early startup performance regression, since timings are then accessible to TBM tests. Also use the newly-introduced events in a couple places, and fix a bug in the TraceEvent we use to record the launcher activity lifetime (when an Activity calls finish from onCreate(), onPause() is not called). BUG=564041 TBR=yfriedman,jam Committed: https://crrev.com/cac088acd2bfd7e76d87db1778a925f8861ab0f7 Cr-Commit-Position: refs/heads/master@{#406264}

Patch Set 1 #

Patch Set 2 : Add the GYP changes back, as they're still needed by WebRTC. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+441 lines, -8 lines) Patch
M base/BUILD.gn View 3 chunks +4 lines, -0 lines 0 comments Download
M base/android/base_jni_registrar.cc View 2 chunks +2 lines, -0 lines 0 comments Download
A base/android/early_trace_event_binding.h View 1 chunk +18 lines, -0 lines 0 comments Download
A base/android/early_trace_event_binding.cc View 1 chunk +46 lines, -0 lines 0 comments Download
A base/android/java/src/org/chromium/base/EarlyTraceEvent.java View 1 chunk +179 lines, -0 lines 0 comments Download
M base/android/java/src/org/chromium/base/TraceEvent.java View 7 chunks +16 lines, -4 lines 0 comments Download
A base/android/javatests/src/org/chromium/base/EarlyTraceEventTest.java View 1 chunk +152 lines, -0 lines 0 comments Download
M base/base.gyp View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/base.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java View 2 chunks +10 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
Benoit L
4 years, 5 months ago (2016-07-19 11:52:58 UTC) #4
phoglund_chromium
lgtm on patch set 2
4 years, 5 months ago (2016-07-19 11:59:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165583002/20001
4 years, 5 months ago (2016-07-19 13:30:04 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-19 13:35:04 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 13:35:09 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 13:37:13 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/cac088acd2bfd7e76d87db1778a925f8861ab0f7
Cr-Commit-Position: refs/heads/master@{#406264}

Powered by Google App Engine
This is Rietveld 408576698