Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(168)

Issue 2142803002: Reland of Android: Add support for TraceEvent before the native library is loaded. (Closed)

Created:
4 years, 5 months ago by Benoit L
Modified:
4 years, 5 months ago
CC:
chromium-reviews, vmpstr+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of Android: Add support for TraceEvent before the native library is loaded. (patchset #1 id:1 of https://codereview.chromium.org/2145443002/ ) Reason for revert: Reland. Original issue's description: > Revert of Android: Add support for TraceEvent before the native library is loaded. (patchset #12 id:220001 of https://codereview.chromium.org/1486053003/ ) > > Reason for revert: > https://crbug.com/627142 > > Original issue's description: > > Android: Add support for TraceEvent before the native library is loaded. > > > > Currently TraceEvents recorded before the native library load are > > silently discarded. This CL adds support for such "early" events. > > > > The events are buffered in Java, and then sent to the native side once > > it is available. This support is intentionally simple now. The aim is to > > ease performance investigation of early startup, and to ease tracking of > > early startup performance regression, since timings are then accessible > > to TBM tests. > > > > Also use the newly-introduced events in a couple places, and fix a bug > > in the TraceEvent we use to record the launcher activity lifetime (when > > an Activity calls finish from onCreate(), onPause() is not called). > > > > BUG=564041 > > > > Committed: https://crrev.com/fb0784294541c53f12e283124672750ab2e291f1 > > Cr-Commit-Position: refs/heads/master@{#404635} > > TBR=pasko@chromium.org,yfriedman@chromium.org,jam@chromium.org,lizeb@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=564041 > > Committed: https://crrev.com/ffda73103b9a84e4739088175b9250a0c28e6f8c > Cr-Commit-Position: refs/heads/master@{#404752} BUG=564041 TBR=jam Committed: https://crrev.com/0267e3c29d74e8a4b0cab629206e14fa02ae2009 Cr-Commit-Position: refs/heads/master@{#405120}

Patch Set 1 #

Patch Set 2 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+438 lines, -8 lines) Patch
M base/BUILD.gn View 1 3 chunks +4 lines, -0 lines 0 comments Download
M base/android/base_jni_registrar.cc View 1 2 chunks +2 lines, -0 lines 0 comments Download
A base/android/early_trace_event_binding.h View 1 chunk +18 lines, -0 lines 0 comments Download
A base/android/early_trace_event_binding.cc View 1 chunk +46 lines, -0 lines 0 comments Download
A base/android/java/src/org/chromium/base/EarlyTraceEvent.java View 1 1 chunk +179 lines, -0 lines 0 comments Download
M base/android/java/src/org/chromium/base/TraceEvent.java View 1 7 chunks +16 lines, -4 lines 0 comments Download
A base/android/javatests/src/org/chromium/base/EarlyTraceEventTest.java View 1 chunk +152 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ChromeApplication.java View 1 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/document/ChromeLauncherActivity.java View 1 2 chunks +10 lines, -4 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/init/AsyncInitializationActivity.java View 1 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 32 (16 generated)
Benoit L
Created Reland of Android: Add support for TraceEvent before the native library is loaded.
4 years, 5 months ago (2016-07-12 08:36:29 UTC) #1
pasko
what are the changes on top of the trivial revert of the revert?
4 years, 5 months ago (2016-07-12 09:29:47 UTC) #2
Benoit L
On 2016/07/12 09:29:47, pasko wrote: > what are the changes on top of the trivial ...
4 years, 5 months ago (2016-07-12 11:18:09 UTC) #3
pasko
lgtm, thank you
4 years, 5 months ago (2016-07-12 11:37:13 UTC) #11
Yaron
lgtm
4 years, 5 months ago (2016-07-12 13:23:10 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142803002/230001
4 years, 5 months ago (2016-07-12 14:24:56 UTC) #17
jam
lgtm
4 years, 5 months ago (2016-07-12 16:20:15 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_ng/builds/242643)
4 years, 5 months ago (2016-07-12 17:06:27 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2142803002/230001
4 years, 5 months ago (2016-07-13 09:49:52 UTC) #22
commit-bot: I haz the power
Committed patchset #2 (id:230001)
4 years, 5 months ago (2016-07-13 11:04:00 UTC) #24
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-13 11:04:07 UTC) #25
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/0267e3c29d74e8a4b0cab629206e14fa02ae2009 Cr-Commit-Position: refs/heads/master@{#405120}
4 years, 5 months ago (2016-07-13 11:05:45 UTC) #27
phoglund_chromium
This is breaking the WebRTC bots when we try to roll Chromium into WebRTC: https://codereview.webrtc.org/2147203002/. ...
4 years, 5 months ago (2016-07-14 11:50:49 UTC) #29
pasko
Feel free to revert, the next working day in PAR is next Monday (2016-07-17).
4 years, 5 months ago (2016-07-14 17:37:44 UTC) #30
pasko
On 2016/07/14 17:37:44, pasko wrote: > Feel free to revert, the next working day in ...
4 years, 5 months ago (2016-07-14 17:40:27 UTC) #31
phoglund_chromium
4 years, 5 months ago (2016-07-15 10:52:09 UTC) #32
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:230001) has been created in
https://codereview.chromium.org/2149993004/ by phoglund@chromium.org.

The reason for reverting is: This is breaking the WebRTC bots when we try to
roll Chromium into WebRTC:
https://codereview.webrtc.org/2147203002/

https://build.chromium.org/p/tryserver.webrtc/builders/android_clang_dbg/buil...

FAILED: lib/libwebrtc_nonparallel_tests.so
...
error: undefined reference to 'base::android::RegisterEarlyTraceEvent(_JNIEnv*)'
.

Powered by Google App Engine
This is Rietveld 408576698