 Chromium Code Reviews
 Chromium Code Reviews Issue 2165573003:
  Simplify tests by using Web*Impl types directly.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master
    
  
    Issue 2165573003:
  Simplify tests by using Web*Impl types directly.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: third_party/WebKit/Source/web/WebRemoteFrameImpl.h | 
| diff --git a/third_party/WebKit/Source/web/WebRemoteFrameImpl.h b/third_party/WebKit/Source/web/WebRemoteFrameImpl.h | 
| index 6bb8a2837f0c13c865a951a4dc3f0c745f9c716a..8a552d08a682066f801b58403b607144f5b16f45 100644 | 
| --- a/third_party/WebKit/Source/web/WebRemoteFrameImpl.h | 
| +++ b/third_party/WebKit/Source/web/WebRemoteFrameImpl.h | 
| @@ -24,7 +24,7 @@ enum class WebFrameLoadType; | 
| class WEB_EXPORT WebRemoteFrameImpl final : public WebFrameImplBase, WTF_NON_EXPORTED_BASE(public WebRemoteFrame) { | 
| public: | 
| - static WebRemoteFrameImpl* create(WebTreeScopeType, WebRemoteFrameClient*, WebFrame* opener); | 
| + static WebRemoteFrameImpl* create(WebTreeScopeType, WebRemoteFrameClient*, WebFrame* opener = nullptr); | 
| 
tkent
2016/07/20 04:51:01
Do you need to add the default argument in this CL
 
dcheng
2016/07/20 06:18:07
WebRemoteFrame::create() has this default arg, so
 
tkent
2016/07/20 06:31:53
Thank you for the explanation.  This is ok as is.
 | 
| ~WebRemoteFrameImpl() override; | 
| // WebFrame methods: |