Simplify tests by using Web*Impl types directly.

third_party/WebKit/Source/web/WebRemoteFrameImpl.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef WebRemoteFrameImpl_h
 #define WebRemoteFrameImpl_h
 
 #include "core/frame/RemoteFrame.h"
 #include "platform/heap/SelfKeepAlive.h"
 #include "public/platform/WebInsecureRequestPolicy.h"
 #include "public/web/WebRemoteFrame.h"
 #include "public/web/WebRemoteFrameClient.h"
 #include "web/RemoteFrameClientImpl.h"
 #include "web/WebExport.h"
 #include "web/WebFrameImplBase.h"
 #include "wtf/Compiler.h"
 
 namespace blink {
 
 class FrameHost;
 class FrameOwner;
 class RemoteFrame;
 enum class WebFrameLoadType;
 
 class WEB_EXPORT WebRemoteFrameImpl final : public WebFrameImplBase, WTF_NON_EXPORTED_BASE(public WebRemoteFrame) {
 public:
-    static WebRemoteFrameImpl* create(WebTreeScopeType, WebRemoteFrameClient*, WebFrame* opener);
+    static WebRemoteFrameImpl* create(WebTreeScopeType, WebRemoteFrameClient*, WebFrame* opener = nullptr);

[tkent, 2016/07/20 04:51:01]

Do you need to add the default argument in this CL?

[dcheng, 2016/07/20 06:18:07]

WebRemoteFrame::create() has this default arg, so it's just to make things
easier. Since this is not a virtual, I opted to just add the default arg, even
though it'd only be useful in unit tests. WDYT?

[tkent, 2016/07/20 06:31:53]

Thank you for the explanation.  This is ok as is.

     ~WebRemoteFrameImpl() override;
 
     // WebFrame methods:
     void close() override;
     WebString uniqueName() const override;
     WebString assignedName() const override;
     void setName(const WebString&) override;
     WebVector<WebIconURL> iconURLs(int iconTypesMask) const override;
     void setRemoteWebLayer(WebLayer*) override;
     void setSharedWorkerRepositoryClient(WebSharedWorkerRepositoryClient*) override;
@@ skipping 113 matching lines @@
     // Accomplish that by keeping a self-referential Persistent<>. It is
     // cleared upon close().
     SelfKeepAlive<WebRemoteFrameImpl> m_selfKeepAlive;
 };
 
 DEFINE_TYPE_CASTS(WebRemoteFrameImpl, WebFrame, frame, frame->isWebRemoteFrame(), frame.isWebRemoteFrame());
 
 } // namespace blink
 
 #endif // WebRemoteFrameImpl_h