Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 216553008: Sync various changes to QuicTestClient. (Closed)

Created:
6 years, 9 months ago by Ryan Hamilton
Modified:
6 years, 8 months ago
Reviewers:
rtennet, ramant (doing other things)
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Sync various changes to QuicTestClient. R=rtennet@chromium.org BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261486

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Patch Set 4 : More cleanups #

Patch Set 5 : More cleanups #

Patch Set 6 : Rebase #

Patch Set 7 : OVERRIDE #

Unified diffs Side-by-side diffs Delta from patch set Stats (+411 lines, -136 lines) Patch
M net/net.gyp View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.h View 1 2 3 4 5 6 5 chunks +81 lines, -40 lines 0 comments Download
M net/tools/quic/test_tools/quic_test_client.cc View 1 2 3 4 5 11 chunks +133 lines, -96 lines 0 comments Download
A net/tools/quic/test_tools/simple_client.h View 1 2 3 4 1 chunk +159 lines, -0 lines 0 comments Download
A net/tools/quic/test_tools/simple_client.cc View 1 2 3 4 1 chunk +36 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
Ryan Hamilton
6 years, 9 months ago (2014-03-28 18:58:40 UTC) #1
Ryan Hamilton
raman: can you take a look
6 years, 8 months ago (2014-04-01 21:30:00 UTC) #2
ramant (doing other things)
lgtm Many many thanks for making these changes. Merging becomes easier.
6 years, 8 months ago (2014-04-02 02:58:42 UTC) #3
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 8 months ago (2014-04-02 03:05:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/216553008/80001
6 years, 8 months ago (2014-04-02 03:05:29 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 05:46:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_rel
6 years, 8 months ago (2014-04-02 05:46:28 UTC) #7
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 8 months ago (2014-04-03 14:01:02 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/216553008/100001
6 years, 8 months ago (2014-04-03 14:01:03 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 15:20:28 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-03 15:20:29 UTC) #11
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 8 months ago (2014-04-03 16:07:22 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/216553008/120001
6 years, 8 months ago (2014-04-03 16:08:06 UTC) #13
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 18:32:10 UTC) #14
Message was sent while issue was closed. 
Change committed as 261486

Powered by Google App Engine
This is Rietveld 408576698