Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1511)

Issue 2165523003: Convert readSurfacePixels to use a draw context instead of a texture (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Convert readSurfacePixels to use a draw context instead of a texture GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2165523003 Committed: https://skia.googlesource.com/skia/+/b117ff194ff888ef9107a4797aad053b0d76be30

Patch Set 1 #

Patch Set 2 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -20 lines) Patch
M src/gpu/GrContext.cpp View 1 3 chunks +13 lines, -16 lines 0 comments Download
M src/gpu/GrGpu.h View 1 1 chunk +1 line, -1 line 0 comments Download
M src/gpu/gl/GrGLGpu.cpp View 1 1 chunk +2 lines, -2 lines 0 comments Download
M src/gpu/vk/GrVkGpu.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
bsalomon
This is motivated by removing instances where we create a DC from a RT rather ...
4 years, 5 months ago (2016-07-19 13:51:41 UTC) #3
Brian Osman
lgtm
4 years, 5 months ago (2016-07-19 13:58:47 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165523003/20001
4 years, 5 months ago (2016-07-19 14:08:45 UTC) #6
robertphillips
lgtm
4 years, 5 months ago (2016-07-19 14:10:49 UTC) #7
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 14:24:45 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/b117ff194ff888ef9107a4797aad053b0d76be30

Powered by Google App Engine
This is Rietveld 408576698