Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(81)

Issue 2158383002: Start from DC rather than texture in GrTexutreParamsAdjuster copy code. (Closed)

Created:
4 years, 5 months ago by bsalomon
Modified:
4 years, 5 months ago
CC:
reviews_skia.org
Base URL:
https://chromium.googlesource.com/skia.git@readpixdc
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Start from DC rather than texture in GrTexutreParamsAdjuster copy code. GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2158383002 Committed: https://skia.googlesource.com/skia/+/916e02a6d004af5b83a636d1507bfdf2da8543ce

Patch Set 1 #

Total comments: 2

Patch Set 2 : Address comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -28 lines) Patch
M src/gpu/GrTextureParamsAdjuster.cpp View 1 3 chunks +15 lines, -28 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 10 (5 generated)
bsalomon
4 years, 5 months ago (2016-07-19 14:28:55 UTC) #3
robertphillips
lgtm https://codereview.chromium.org/2158383002/diff/1/src/gpu/GrTextureParamsAdjuster.cpp File src/gpu/GrTextureParamsAdjuster.cpp (right): https://codereview.chromium.org/2158383002/diff/1/src/gpu/GrTextureParamsAdjuster.cpp#newcode72 src/gpu/GrTextureParamsAdjuster.cpp:72: // Initializing these values for no reason cause ...
4 years, 5 months ago (2016-07-19 14:41:17 UTC) #4
bsalomon
https://codereview.chromium.org/2158383002/diff/1/src/gpu/GrTextureParamsAdjuster.cpp File src/gpu/GrTextureParamsAdjuster.cpp (right): https://codereview.chromium.org/2158383002/diff/1/src/gpu/GrTextureParamsAdjuster.cpp#newcode72 src/gpu/GrTextureParamsAdjuster.cpp:72: // Initializing these values for no reason cause the ...
4 years, 5 months ago (2016-07-19 14:52:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2158383002/20001
4 years, 5 months ago (2016-07-19 14:52:58 UTC) #8
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 15:12:33 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/916e02a6d004af5b83a636d1507bfdf2da8543ce

Powered by Google App Engine
This is Rietveld 408576698