Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Issue 2165453003: command buffer: remove unused code in GLES2DecoderImpl (Closed)

Created:
4 years, 5 months ago by yunchao
Modified:
4 years, 5 months ago
CC:
chromium-reviews, piman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

command buffer: remove unused code in GLES2DecoderImpl. ERRORSTATE_SET_GL_ERROR_INVALID_PARAM has been removed. It is not defined at all now. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/dfabf15df7689b76d0a983197f7365d6b35738ef Cr-Commit-Position: refs/heads/master@{#406290}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -3 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (10 generated)
yunchao
A small change. PTAL.
4 years, 5 months ago (2016-07-19 14:29:49 UTC) #8
Zhenyao Mo
On 2016/07/19 14:29:49, yunchao wrote: > A small change. PTAL. lgtm
4 years, 5 months ago (2016-07-19 16:14:14 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165453003/1
4 years, 5 months ago (2016-07-19 16:14:43 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-19 16:19:16 UTC) #13
commit-bot: I haz the power
CQ bit was unchecked.
4 years, 5 months ago (2016-07-19 16:19:19 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-19 16:20:55 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/dfabf15df7689b76d0a983197f7365d6b35738ef
Cr-Commit-Position: refs/heads/master@{#406290}

Powered by Google App Engine
This is Rietveld 408576698