Support Big Endian part 2

Support Big Endian part 2

Follow-up CL to https://codereview.chromium.org/2162393003

1. make_data_assembly now accepts '--mac' to generate assembly source
for Mac

2.  Fix icu.gyp to support all platforms


BUG=v8:4828
TEST='d8' is built correct with icu_use_data_file set to either 0 or 1 on Mac/Linux
TEST=run `GYP_DEFINES="target_arch=mips" ./gypfiles/gyp_v8` and make sure
that ninja files use 'b' data/assembly file for Big Endian on Mac/Linux

R=machenbach@chromium.org

Committed: https://chromium.googlesource.com/chromium/deps/icu/+/4c2855af8be11ec0701796a02380d8f7269be25e

[jungshik at Google, 2016-07-21 23:06:07]

jshin@chromium.org changed reviewers:
+ machenbach@chromium.org

[jungshik at Google, 2016-07-21 23:06:08]

Can you take a look? Thanks 

I'll follow this up with BUILD.gn change (and removal of all 3 assembly source
files that are generated on the fly from icudt[bl].dat).

[Michael Achenbach, 2016-07-22 07:34:09]

lgtm

rubber stamp on the python file details. I'm not an expert there, maybe you need
to refer to an owner of that file.

https://codereview.chromium.org/2165403003/diff/1/icu.gyp
File icu.gyp (right):

https://codereview.chromium.org/2165403003/diff/1/icu.gyp#newcode120
icu.gyp:120: 'data_assembly_inputs': [
Not enough gyp knowledge here. Can we just declare variables in a target block?
No need for a variables block?

https://codereview.chromium.org/2165403003/diff/1/icu.gyp#newcode170
icu.gyp:170: [ 'OS != "mac" and OS != "ios" and '
Optional: I have the feeling the condition might be easier to read if turned
around.

https://codereview.chromium.org/2165403003/diff/1/scripts/make_data_assembly.py
File scripts/make_data_assembly.py (right):

https://codereview.chromium.org/2165403003/diff/1/scripts/make_data_assembly....
scripts/make_data_assembly.py:51: output.write(".globl _icudt%s_dat\n"
I have no idea about this and can only rubber stamp.

[jungshik at Google, 2016-07-22 20:31:13]

Thanks for taking a look. Your suggestion helped me make gyp a bit simpler. I'm
landing it now.

https://codereview.chromium.org/2165403003/diff/1/icu.gyp
File icu.gyp (right):

https://codereview.chromium.org/2165403003/diff/1/icu.gyp#newcode120
icu.gyp:120: 'data_assembly_inputs': [
On 2016/07/22 07:34:08, Michael Achenbach (slow) wrote:
> Not enough gyp knowledge here. Can we just declare variables in a target
block?
> No need for a variables block?

Yeah. It works. Thank you for the suggestion.

https://codereview.chromium.org/2165403003/diff/1/icu.gyp#newcode170
icu.gyp:170: [ 'OS != "mac" and OS != "ios" and '
On 2016/07/22 07:34:08, Michael Achenbach (slow) wrote:
> Optional: I have the feeling the condition might be easier to read if turned
> around.

Yes !!  I was copying/moving the condition from the previous location (where
mac/icudtl_dat.S used to be used). Turning it around made it much easier to
read.

https://codereview.chromium.org/2165403003/diff/1/scripts/make_data_assembly.py
File scripts/make_data_assembly.py (right):

https://codereview.chromium.org/2165403003/diff/1/scripts/make_data_assembly....
scripts/make_data_assembly.py:51: output.write(".globl _icudt%s_dat\n"
On 2016/07/22 07:34:08, Michael Achenbach (slow) wrote:
> I have no idea about this and can only rubber stamp.

Thanks. Don't worry. It comes from scripts/make_mac_assembly.sh. Mac assembly is
slightly different than Linux'.

[jungshik at Google, 2016-07-22 20:31:37]

Description was changed from

==========
Support Big Endian part 2

Follow-up CL to https://codereview.chromium.org/2162393003

1. make_data_assembly now accepts '--mac' to generate assembly source
for Mac

2.  Fix icu.gyp to support all platforms


BUG=v8:4828
TEST='d8' is built correct with icu_use_data_file set to either 0 or 1 on
Mac/Linux
TEST=run `GYP_DEFINES="target_arch=mips" ./gypfiles/gyp_v8` and make sure
that ninja files use 'b' data/assembly file for Big Endian on Mac/Linux
==========

to

==========
Support Big Endian part 2

Follow-up CL to https://codereview.chromium.org/2162393003

1. make_data_assembly now accepts '--mac' to generate assembly source
for Mac

2.  Fix icu.gyp to support all platforms


BUG=v8:4828
TEST='d8' is built correct with icu_use_data_file set to either 0 or 1 on
Mac/Linux
TEST=run `GYP_DEFINES="target_arch=mips" ./gypfiles/gyp_v8` and make sure
that ninja files use 'b' data/assembly file for Big Endian on Mac/Linux

R=machenbach@chromium.org

Committed:
https://chromium.googlesource.com/chromium/deps/icu/+/4c2855af8be11ec0701796a...
==========

[jungshik at Google, 2016-07-22 20:31:38]

Committed patchset #2 (id:20001) manually as
4c2855af8be11ec0701796a02380d8f7269be25e (presubmit successful).