Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 2165313002: [FRE] Clean unused and not needed properties and interface (Closed)

Created:
4 years, 5 months ago by gogerald1
Modified:
4 years, 5 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean unused and not needed properties and interface The interface has been broken for a long time. BUG= Committed: https://crrev.com/946a1dc207b617e27e83cb9d7af42ffd87dd8f59 Cr-Commit-Position: refs/heads/master@{#407155}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -26 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPage.java View 2 chunks +0 lines, -25 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPagerAdapter.java View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 16 (11 generated)
gogerald1
Hi, PTAL,
4 years, 5 months ago (2016-07-21 15:59:26 UTC) #4
Bernhard Bauer
lgtm
4 years, 5 months ago (2016-07-22 14:17:15 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165313002/1
4 years, 5 months ago (2016-07-22 14:38:21 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 5 months ago (2016-07-22 14:41:55 UTC) #14
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 14:44:09 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/946a1dc207b617e27e83cb9d7af42ffd87dd8f59
Cr-Commit-Position: refs/heads/master@{#407155}

Powered by Google App Engine
This is Rietveld 408576698