Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2639)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPage.java

Issue 2165313002: [FRE] Clean unused and not needed properties and interface (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPagerAdapter.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPage.java b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPage.java
index d424dfd620854c6cee051130c916e7dc8a685798..7221c6ff8ef203b80f62f21e5d3c39647d389302 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPage.java
@@ -14,24 +14,6 @@ import android.os.Bundle;
public class FirstRunPage extends Fragment {
private Bundle mProperties = new Bundle();
- // FRE properties:
- private static final String LAST_PAGE_NUMBER = "LastPageNumber";
-
- // Per-page properties:
- private static final String THIS_PAGE_NUMBER = "ThisPageNumber";
-
- /**
- * Appends page-specific properties to the page instance bundle.
- * @param props Instance properties.
- * @param pageNumber This page number in the First Run sequence.
- * @param lastPageNumber Last page number in the First Run sequence.
- * @return Instance properties with the page-specific properties added.
- */
- public static Bundle addProperties(Bundle props, int pageNumber, int lastPageNumber) {
- props.putInt(THIS_PAGE_NUMBER, pageNumber);
- return props;
- }
-
/**
* @return Whether this page should be skipped on the FRE creation.
* @param appContext An application context.
@@ -81,13 +63,6 @@ public class FirstRunPage extends Fragment {
}
/**
- * @return Whether this page is the last page of the FRE.
- */
- protected boolean isLastPage() {
- return getProperties().getInt(THIS_PAGE_NUMBER) == getProperties().getInt(LAST_PAGE_NUMBER);
- }
-
- /**
* Advances to the next FRE page.
*/
protected void advanceToNextPage() {
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunPagerAdapter.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698