Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(877)

Issue 2165243002: Make TexImage2D(ImageBitmap) supports some more formats (Closed)

Created:
4 years, 5 months ago by xidachen
Modified:
4 years, 5 months ago
CC:
chromium-reviews, blink-reviews, haraken
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make TexImage2D(ImageBitmap) supports some more formats With crbug.com/626431 fixed, texImage2D(ImageBitmap) is able to support more formats for WebGL2. BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/893a850c8714babe8a5d480ce1328cfc8a1e8b92 Cr-Commit-Position: refs/heads/master@{#406858}

Patch Set 1 #

Total comments: 1

Patch Set 2 : nits #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
xidachen
PTAL
4 years, 5 months ago (2016-07-21 14:01:13 UTC) #3
Zhenyao Mo
lgtm if tests are passing https://codereview.chromium.org/2165243002/diff/1/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp File third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp (right): https://codereview.chromium.org/2165243002/diff/1/third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp#newcode4527 third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp:4527: // TODO(xidachen): find out ...
4 years, 5 months ago (2016-07-21 14:03:39 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165243002/20001
4 years, 5 months ago (2016-07-21 15:29:04 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-21 15:32:32 UTC) #12
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/893a850c8714babe8a5d480ce1328cfc8a1e8b92 Cr-Commit-Position: refs/heads/master@{#406858}
4 years, 5 months ago (2016-07-21 15:34:47 UTC) #14
Ken Russell (switch to Gerrit)
4 years, 5 months ago (2016-07-22 00:57:20 UTC) #15
Message was sent while issue was closed.
Thanks, LGTM after the fact, but in the future I'd really appreciate it if you
could link to some bug ID. It's hard to backtrack to these CLs that don't have
any associated bug ID when diagnosing issues later.

Powered by Google App Engine
This is Rietveld 408576698