Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(462)

Issue 2165183003: Convert some component source sets to static library (Closed)

Created:
4 years, 5 months ago by brettw
Modified:
4 years, 5 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, rsleevi+watch_chromium.org, certificate-transparency-chrome_googlegroups.com, msramek+watch_chromium.org, jam, sadrul, Eran Messeri, rouslan+autofill_chromium.org, tfarina, devtools-reviews_chromium.org, browser-components-watch_chromium.org, raymes+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, eme-reviews_chromium.org, kalyank, noyau+watch_chromium.org, pfeldman, darin-cc_chromium.org, vabr+watchlistautofill_chromium.org, estade+watch_chromium.org, markusheintz_, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert some component source sets to static library This is hoping to achieve better build performance. BUG=627637 Committed: https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579 Cr-Commit-Position: refs/heads/master@{#407052}

Patch Set 1 #

Patch Set 2 : mac fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -29 lines) Patch
M components/about_handler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/auto_login_parser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/autofill/core/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/base32/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/bookmarks/managed/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/browser_sync/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/cdm/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/certificate_transparency/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/client_update_protocol/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/constrained_window/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/content/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/content_settings/core/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/cookie_config/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/crash/content/app/BUILD.gn View 1 2 chunks +2 lines, -2 lines 0 comments Download
M components/crash/content/tools/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/crash/core/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/crx_file/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/content/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/BUILD.gn View 2 chunks +2 lines, -2 lines 0 comments Download
M components/data_reduction_proxy/core/common/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/data_usage/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/data_use_measurement/content/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M components/data_use_measurement/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/devtools_discovery/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/devtools_http_handler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (8 generated)
brettw
4 years, 5 months ago (2016-07-21 21:12:55 UTC) #3
Dirk Pranke
lgtm
4 years, 5 months ago (2016-07-21 21:49:13 UTC) #5
brettw
mac fix
4 years, 5 months ago (2016-07-21 21:58:14 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2165183003/20001
4 years, 5 months ago (2016-07-21 21:59:26 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 5 months ago (2016-07-22 03:56:25 UTC) #12
commit-bot: I haz the power
4 years, 5 months ago (2016-07-22 03:59:23 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8deee3907ceb2dd0439fb6d2be9b3f07d6968579
Cr-Commit-Position: refs/heads/master@{#407052}

Powered by Google App Engine
This is Rietveld 408576698