components/crash/content/app/BUILD.gn - Issue 2165183003: Convert some component source sets to static library

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/crash/content/app/BUILD.gn

Issue 2165183003: Convert some component source sets to static library (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: mac fix Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/crash/content/app/BUILD.gn

diff --git a/components/crash/content/app/BUILD.gn b/components/crash/content/app/BUILD.gn

index 0e5d6e0bfd92d48292120e3b764662b4f3a48003..f1e136dfdc426561061ceb7771b61a16e89008ea 100644

--- a/components/crash/content/app/BUILD.gn

+++ b/components/crash/content/app/BUILD.gn

@@ -146,7 +146,7 @@ source_set("app_non_mac_win") {

# removed shortly and all consumers will be expected to use Crashpad as

# the Mac crash-reporting client. See the comment in the

# crash_component_non_mac target for more details.

-source_set("app_breakpad_mac_win_to_be_deleted") {

+static_library("app_breakpad_mac_win_to_be_deleted") {

deps = [

":app_non_mac_win",

]

@@ -185,7 +185,7 @@ source_set("app_breakpad_mac_win_to_be_deleted") {

}

if (is_mac) {

- source_set("breakpad_stubs") {

+ static_library("breakpad_stubs") {

sources = [

"breakpad_mac.h",

"breakpad_mac_stubs.mm",

« no previous file with comments | « components/cookie_config/BUILD.gn ('k') | components/crash/content/tools/BUILD.gn » ('j') | no next file with comments »