Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1704)

Unified Diff: chrome/browser/extensions/api/storage/managed_value_store_cache.cc

Issue 216513002: Replace DCHECK(BrowserThread::CurrentlyOn) with DCHECK_CURRENTLY_ON in extensions. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/storage/managed_value_store_cache.cc
diff --git a/chrome/browser/extensions/api/storage/managed_value_store_cache.cc b/chrome/browser/extensions/api/storage/managed_value_store_cache.cc
index 562117beaa8b5c3ad6cb4175ca62458b90ef3a20..814d949fd296531b2bcded6c512b928a201f6a7d 100644
--- a/chrome/browser/extensions/api/storage/managed_value_store_cache.cc
+++ b/chrome/browser/extensions/api/storage/managed_value_store_cache.cc
@@ -221,7 +221,7 @@ void ManagedValueStoreCache::ExtensionTracker::LoadSchemasOnBlockingPool(
void ManagedValueStoreCache::ExtensionTracker::Register(
const policy::ComponentMap* components) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
schema_registry_->RegisterComponents(policy::POLICY_DOMAIN_EXTENSIONS,
*components);
@@ -245,7 +245,7 @@ ManagedValueStoreCache::ManagedValueStoreCache(
observers_(observers),
base_path_(profile_->GetPath().AppendASCII(
extensions::kManagedSettingsDirectoryName)) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
policy_service_->AddObserver(policy::POLICY_DOMAIN_EXTENSIONS, this);
@@ -258,13 +258,13 @@ ManagedValueStoreCache::ManagedValueStoreCache(
}
ManagedValueStoreCache::~ManagedValueStoreCache() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);
// Delete the PolicyValueStores on FILE.
store_map_.clear();
}
void ManagedValueStoreCache::ShutdownOnUI() {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
policy_service_->RemoveObserver(policy::POLICY_DOMAIN_EXTENSIONS, this);
extension_tracker_.reset();
}
@@ -272,13 +272,13 @@ void ManagedValueStoreCache::ShutdownOnUI() {
void ManagedValueStoreCache::RunWithValueStoreForExtension(
const StorageCallback& callback,
scoped_refptr<const Extension> extension) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);
callback.Run(GetStoreFor(extension->id()));
}
void ManagedValueStoreCache::DeleteStorageSoon(
const std::string& extension_id) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);
// It's possible that the store exists, but hasn't been loaded yet
// (because the extension is unloaded, for example). Open the database to
// clear it if it exists.
@@ -290,7 +290,7 @@ void ManagedValueStoreCache::DeleteStorageSoon(
void ManagedValueStoreCache::OnPolicyServiceInitialized(
policy::PolicyDomain domain) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (domain != policy::POLICY_DOMAIN_EXTENSIONS)
return;
@@ -318,7 +318,7 @@ void ManagedValueStoreCache::OnPolicyServiceInitialized(
void ManagedValueStoreCache::OnPolicyUpdated(const policy::PolicyNamespace& ns,
const policy::PolicyMap& previous,
const policy::PolicyMap& current) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
if (!policy_service_->IsInitializationComplete(
policy::POLICY_DOMAIN_EXTENSIONS)) {
@@ -339,7 +339,7 @@ void ManagedValueStoreCache::OnPolicyUpdated(const policy::PolicyNamespace& ns,
void ManagedValueStoreCache::UpdatePolicyOnFILE(
const std::string& extension_id,
scoped_ptr<policy::PolicyMap> current_policy) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);
if (!HasStore(extension_id) && current_policy->empty()) {
// Don't create the store now if there are no policies configured for this
@@ -353,7 +353,7 @@ void ManagedValueStoreCache::UpdatePolicyOnFILE(
PolicyValueStore* ManagedValueStoreCache::GetStoreFor(
const std::string& extension_id) {
- DCHECK(BrowserThread::CurrentlyOn(BrowserThread::FILE));
+ DCHECK_CURRENTLY_ON(BrowserThread::FILE);
PolicyValueStoreMap::iterator it = store_map_.find(extension_id);
if (it != store_map_.end())

Powered by Google App Engine
This is Rietveld 408576698