Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4747)

Unified Diff: chrome/browser/android/data_usage/external_data_use_observer.cc

Issue 2165123002: Make ExternalDataUseReporter independent of other data use classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed nits Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/data_usage/external_data_use_observer.cc
diff --git a/chrome/browser/android/data_usage/external_data_use_observer.cc b/chrome/browser/android/data_usage/external_data_use_observer.cc
index af047556ff4ecb0e1bdd911f669115f03b52bfc6..3d78fc9546605523cc622858d2ec9162e38acc0e 100644
--- a/chrome/browser/android/data_usage/external_data_use_observer.cc
+++ b/chrome/browser/android/data_usage/external_data_use_observer.cc
@@ -63,10 +63,16 @@ ExternalDataUseObserver::ExternalDataUseObserver(
base::Bind(
&ExternalDataUseObserverBridge::ShouldRegisterAsDataUseObserver,
base::Unretained(external_data_use_observer_bridge_)))),
- external_data_use_reporter_(
- new ExternalDataUseReporter(kExternalDataUseObserverFieldTrial,
- data_use_tab_model_,
- external_data_use_observer_bridge_)),
+ // It is okay to use base::Unretained for the callbacks, since
+ // |external_data_use_observer_bridge_| and |data_use_tab_model_| are
+ // owned by |this|, and are destroyed on UI thread after |this| and
+ // |external_data_use_reporter_| are destroyed.
+ external_data_use_reporter_(new ExternalDataUseReporter(
+ kExternalDataUseObserverFieldTrial,
+ base::Bind(&DataUseTabModel::GetTrackingInfoForTabAtTime,
+ base::Unretained(data_use_tab_model_)),
+ base::Bind(&ExternalDataUseObserverBridge::ReportDataUse,
+ base::Unretained(external_data_use_observer_bridge_)))),
io_task_runner_(io_task_runner),
ui_task_runner_(ui_task_runner),
last_matching_rules_fetch_time_(base::TimeTicks::Now()),

Powered by Google App Engine
This is Rietveld 408576698