chrome/browser/android/data_usage/data_use_tab_model.cc - Issue 2165123002: Make ExternalDataUseReporter independent of other data use classes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/android/data_usage/data_use_tab_model.cc

Issue 2165123002: Make ExternalDataUseReporter independent of other data use classes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed nits Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/android/data_usage/data_use_tab_model.cc

diff --git a/chrome/browser/android/data_usage/data_use_tab_model.cc b/chrome/browser/android/data_usage/data_use_tab_model.cc

index 14d7f3b29aa5dd7b62158f6c7b1c12fa2549f82d..3a67b5d94c8df78dc2b459e0d510c93784e98e3b 100644

--- a/chrome/browser/android/data_usage/data_use_tab_model.cc

+++ b/chrome/browser/android/data_usage/data_use_tab_model.cc

@@ -222,7 +222,7 @@ void DataUseTabModel::OnTrackingLabelRemoved(const std::string& label) {

bool DataUseTabModel::GetTrackingInfoForTabAtTime(

SessionID::id_type tab_id,

- base::TimeTicks timestamp,

+ const base::TimeTicks timestamp,

TrackingInfo* output_tracking_info) const {

DCHECK(thread_checker_.CalledOnValidThread());

« no previous file with comments | « no previous file | chrome/browser/android/data_usage/external_data_use_observer.cc » ('j') | no next file with comments »