Split NewScope into NewScope and NewScopeWithParent

Split NewScope into NewScope and NewScopeWithParent

NewScope automatically uses scope(), whereas NewScopeWithParent can pass along any local Scope* as outer scope. The number of calls to NewScopeWithParent should be reduced over time.

BUG=v8:5209
Committed: https://crrev.com/2ca608041bc0375d20340e59a3d941987f95314e
Cr-Commit-Position: refs/heads/master@{#37912}

[Toon Verwaest, 2016-07-20 09:04:31]

verwaest@chromium.org changed reviewers:
+ marja@chromium.org

[Toon Verwaest, 2016-07-20 09:04:31]

ptal

[marja, 2016-07-20 09:15:32]

https://codereview.chromium.org/2164943002/diff/1/src/parsing/parser.h
File src/parsing/parser.h (right):

https://codereview.chromium.org/2164943002/diff/1/src/parsing/parser.h#newcod...
src/parsing/parser.h:547: V8_INLINE Scope* NewManualScope(Scope* parent,
ScopeType scope_type);
I don't like "Manual" in the name, how about something along the lines of
NewScopeWithParent or such?

[Toon Verwaest, 2016-07-20 11:36:31]

Thanks. I addressed the comment and added a comment that the constructor should
be used sparingly.

[Toon Verwaest, 2016-07-20 11:36:54]

Description was changed from

==========
Split NewScope into NewScope and NewManualScope

NewScope automatically uses scope(), whereas NewManualScope can pass along any
local Scope* as outer scope.
The number of calls to NewManualScope should be reduced over time.

BUG=v8:5209
==========

to

==========
Split NewScope into NewScope and NewScopeWithParent

NewScope automatically uses scope(), whereas NewScopeWithParent can pass along
any local Scope* as outer scope. The number of calls to NewScopeWithParent
should be reduced over time.

BUG=v8:5209
==========

[marja, 2016-07-20 11:39:34]

lgtm

[Toon Verwaest, 2016-07-20 14:19:03]

The CQ bit was checked by verwaest@chromium.org

[commit-bot: I haz the power, 2016-07-20 14:19:10]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-07-20 14:42:05]

Description was changed from

==========
Split NewScope into NewScope and NewScopeWithParent

NewScope automatically uses scope(), whereas NewScopeWithParent can pass along
any local Scope* as outer scope. The number of calls to NewScopeWithParent
should be reduced over time.

BUG=v8:5209
==========

to

==========
Split NewScope into NewScope and NewScopeWithParent

NewScope automatically uses scope(), whereas NewScopeWithParent can pass along
any local Scope* as outer scope. The number of calls to NewScopeWithParent
should be reduced over time.

BUG=v8:5209
==========

[commit-bot: I haz the power, 2016-07-20 14:42:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-07-20 14:43:47]

Description was changed from

==========
Split NewScope into NewScope and NewScopeWithParent

NewScope automatically uses scope(), whereas NewScopeWithParent can pass along
any local Scope* as outer scope. The number of calls to NewScopeWithParent
should be reduced over time.

BUG=v8:5209
==========

to

==========
Split NewScope into NewScope and NewScopeWithParent

NewScope automatically uses scope(), whereas NewScopeWithParent can pass along
any local Scope* as outer scope. The number of calls to NewScopeWithParent
should be reduced over time.

BUG=v8:5209

Committed: https://crrev.com/2ca608041bc0375d20340e59a3d941987f95314e
Cr-Commit-Position: refs/heads/master@{#37912}
==========

[commit-bot: I haz the power, 2016-07-20 14:43:48]

Patchset 2 (id:??) landed as
https://crrev.com/2ca608041bc0375d20340e59a3d941987f95314e
Cr-Commit-Position: refs/heads/master@{#37912}